From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNkcj-0001r0-KL for qemu-devel@nongnu.org; Thu, 04 Apr 2013 09:54:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNkcb-0005N9-Po for qemu-devel@nongnu.org; Thu, 04 Apr 2013 09:54:41 -0400 Received: from greensocs.com ([87.106.252.221]:59636 helo=s15328186.onlinehome-server.info) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNkcb-0005Mk-JO for qemu-devel@nongnu.org; Thu, 04 Apr 2013 09:54:33 -0400 Message-ID: <515D8614.4040301@greensocs.com> Date: Thu, 04 Apr 2013 15:54:28 +0200 From: =?ISO-8859-1?Q?KONRAD_Fr=E9d=E9ric?= MIME-Version: 1.0 References: <1364547764-6627-1-git-send-email-fred.konrad@greensocs.com> <1364547764-6627-2-git-send-email-fred.konrad@greensocs.com> <20130403085357.2d571f86@gondolin> In-Reply-To: <20130403085357.2d571f86@gondolin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/7] virtio-serial: add the virtio-serial device. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Amit Shah , peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org On 03/04/2013 08:53, Cornelia Huck wrote: > On Fri, 29 Mar 2013 10:02:38 +0100 > fred.konrad@greensocs.com wrote: > >> From: KONRAD Frederic >> >> Create virtio-serial which extends virtio-device, so it can be connected >> on virtio-bus. >> >> Signed-off-by: KONRAD Frederic >> --- >> hw/virtio-pci.c | 2 +- >> hw/virtio-serial-bus.c | 95 ++++++++++++++++++++++++++++++++++++++++++++++---- >> hw/virtio-serial.h | 9 +++++ >> 3 files changed, 98 insertions(+), 8 deletions(-) >> >> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c >> index fb20722..6db67bf 100644 >> --- a/hw/virtio-pci.c >> +++ b/hw/virtio-pci.c >> @@ -1075,7 +1075,7 @@ static Property virtio_serial_properties[] = { >> DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2), >> DEFINE_PROP_HEX32("class", VirtIOPCIProxy, class_code, 0), >> DEFINE_VIRTIO_COMMON_FEATURES(VirtIOPCIProxy, host_features), >> - DEFINE_PROP_UINT32("max_ports", VirtIOPCIProxy, serial.max_virtserial_ports, 31), >> + DEFINE_VIRTIO_SERIAL_PROPERTIES(VirtIOPCIProxy, serial), >> DEFINE_PROP_END_OF_LIST(), >> }; >> > Any reason why you convert only virtio-pci to the new define? > s390-virtio and virtio-ccw could use it as well. > > No reason, I'll make the change thanks. Fred