From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH v2 05/10] elfload: use abi_int/uint instead of target_int/uint
Date: Thu, 04 Apr 2013 16:04:07 +0200 [thread overview]
Message-ID: <515D8857.1090204@redhat.com> (raw)
In-Reply-To: <CAFEAcA85THVKLtynoZU3fBhgyXN2-gMHg2CDsvE__Cj9ZFgz2g@mail.gmail.com>
Il 04/04/2013 15:56, Peter Maydell ha scritto:
>> > #define TARGET_LONG_BITS 32
>> > +#define ABI_INT_ALIGNMENT 2
>> >
>> > #define CPUArchState struct CPUM68KState
> I think this define should go in an include file in
> linux-user/m68k/ -- it's ABI specific and we should
> be aiming to isolate ABI specific info in linux-user/
> rather than having it leaking into target-* and thus
> into the system emulation code.
>
> Otherwise patch looks good.
That would create 10 empty files, and two files between one and three
lines of code. I would just put those in include/exec/user/abitypes.h.
WDYT?
Paolo
next prev parent reply other threads:[~2013-04-04 14:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 10:31 [Qemu-devel] [PATCH v2 00/10] TARGET_*_ALIGNMENT cleanup, and config-target.mak trimming Paolo Bonzini
2013-04-03 10:31 ` [Qemu-devel] [PATCH v2 01/10] elfload: fix size of ABI-dependent fields in core dumps Paolo Bonzini
2013-04-04 13:51 ` Peter Maydell
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 02/10] elfload: fix size of registers for N32 Paolo Bonzini
2013-04-04 15:32 ` Peter Maydell
2013-04-04 15:41 ` Paolo Bonzini
2013-04-04 15:46 ` Peter Maydell
2013-04-04 16:00 ` Paolo Bonzini
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 03/10] elfload: use tswapreg consistently in elf_core_copy_regs Paolo Bonzini
2013-04-04 15:33 ` Peter Maydell
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 04/10] elfload: use abi_short/ushort instead of target_short/ushort Paolo Bonzini
2013-04-04 13:52 ` Peter Maydell
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 05/10] elfload: use abi_int/uint instead of target_int/uint Paolo Bonzini
2013-04-04 13:56 ` Peter Maydell
2013-04-04 14:04 ` Paolo Bonzini [this message]
2013-04-04 14:22 ` Peter Maydell
2013-04-04 14:28 ` Paolo Bonzini
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 06/10] elfload: only give abi_long/ulong the alignment specified by the target Paolo Bonzini
2013-04-04 14:09 ` Peter Maydell
2013-04-04 14:11 ` Paolo Bonzini
2013-04-04 14:18 ` Peter Maydell
2013-04-04 14:26 ` Paolo Bonzini
2013-04-04 14:37 ` Peter Maydell
2013-04-04 14:45 ` Paolo Bonzini
2013-04-04 14:50 ` Peter Maydell
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 07/10] elfload: use abi_llong/ullong instead of target_llong/ullong Paolo Bonzini
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 08/10] configure: move CONFIG_QEMU_LDST_OPTIMIZATION to config-host.mak Paolo Bonzini
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 09/10] configure: move common libraries " Paolo Bonzini
2013-04-04 13:40 ` Peter Maydell
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 10/10] configure: CONFIG_NO_XEN is duplicated Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515D8857.1090204@redhat.com \
--to=pbonzini@redhat.com \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.