Re: [PATCH v2] pps: hide more configuration symbols behind CONFIG_PPS

[Florian Fainelli <florian@openwrt.org>]

Le 01/15/13 17:24, Florian Fainelli a écrit :
> This patch makes CONFIG_PPS_DEBUG and CONFIG_NTP_PPS be hidden if
> CONFIG_PPS is not selected, such that we are not prompted for these
> configuration options if CONFIG_PPS is not set.

It seems like this patch has not been merged, yet it is still applicable 
as of 3.9-rc. Andrew can you take it maybe? Thanks!

>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> Changes since v1:
> - dropped the depends on PPS which is now useless
>
>   drivers/pps/Kconfig |    6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig
> index 982d16b..7512e98 100644
> --- a/drivers/pps/Kconfig
> +++ b/drivers/pps/Kconfig
> @@ -20,10 +20,10 @@ config PPS
>
>   	  To compile this driver as a module, choose M here: the module
>   	  will be called pps_core.ko.
> +if PPS
>
>   config PPS_DEBUG
>   	bool "PPS debugging messages"
> -	depends on PPS
>   	help
>   	  Say Y here if you want the PPS support to produce a bunch of debug
>   	  messages to the system log.  Select this if you are having a
> @@ -31,13 +31,15 @@ config PPS_DEBUG
>
>   config NTP_PPS
>   	bool "PPS kernel consumer support"
> -	depends on PPS && !NO_HZ
> +	depends on !NO_HZ
>   	help
>   	  This option adds support for direct in-kernel time
>   	  synchronization using an external PPS signal.
>
>   	  It doesn't work on tickless systems at the moment.
>
> +endif
> +
>   source drivers/pps/clients/Kconfig
>
>   source drivers/pps/generators/Kconfig
>