From: Richard Kuo <rkuo@codeaurora.org>
To: linasvepstas@gmail.com
Cc: linux-arch@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 4/6] Hexagon: check to if we will overflow the signal stack
Date: Thu, 04 Apr 2013 11:58:58 -0500 [thread overview]
Message-ID: <515DB152.603@codeaurora.org> (raw)
In-Reply-To: <CAHrUA37oTkv-x5f4zZVwqjWAqvyMdwXAokw1EDBHiGv8ozWxVQ@mail.gmail.com>
On 04/04/2013 11:25 AM, Linas Vepstas wrote:
> On 3 April 2013 19:02, Richard Kuo <rkuo@codeaurora.org> wrote:
>
>> + /* check if we would overflow the alt stack */
>> + if (on_sig_stack(sp) && !likely(on_sig_stack(sp - frame_size)))
>> + return (void __user __force *)-1UL;
> I found the !likely construction confusing, as its doing both a
> 'unlikely' (right?) and inverting the argument. It seems clearer,
> to idiots like me, to write this as:
>
> if (on_sig_stack(sp) && unlikely(!on_sig_stack(sp - frame_size)))
>
> since where checking for overflow, and its unlikely that the overflow happened.
>
> -- Linas
I'm not sure if putting a double negative in there will make it less not
easy to understand...
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-04-04 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 0:02 [PATCH 0/6] Hexagon: various signal and return path cleanups Richard Kuo
2013-04-04 0:02 ` [PATCH 1/6] Hexagon: Signal and return path fixes Richard Kuo
2013-04-04 0:02 ` [PATCH 2/6] Hexagon: fix up int enable/disable at ret_from_fork Richard Kuo
2013-04-04 0:02 ` [PATCH 3/6] Hexagon: use correct work mask when checking for more work Richard Kuo
2013-04-04 0:02 ` [PATCH 4/6] Hexagon: check to if we will overflow the signal stack Richard Kuo
2013-04-04 16:25 ` Linas Vepstas
2013-04-04 16:58 ` Richard Kuo [this message]
2013-04-04 0:02 ` [PATCH 5/6] Hexagon: break up user fn/arg register setting Richard Kuo
2013-04-04 0:02 ` [PATCH 6/6] Hexagon: fix psp/sp macro Richard Kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515DB152.603@codeaurora.org \
--to=rkuo@codeaurora.org \
--cc=linasvepstas@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.