All of lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)
Date: Thu, 4 Apr 2013 14:48:51 -0700	[thread overview]
Message-ID: <515DF543.7000801@freescale.com> (raw)
In-Reply-To: <20130404214736.0AC302015BE@gemini.denx.de>

On 04/04/2013 02:47 PM, Wolfgang Denk wrote:
> Dear York Sun,
> 
> In message <515DEED2.90908@freescale.com> you wrote:
>>
>> Would this fix be acceptable?
> 
> No...
> 
>> +#ifdef true
>> +#undef true
>> +#undef false
>> +
>>  U_BOOT_CMD(
>>         false,  CONFIG_SYS_MAXARGS,     1,      do_false,
>>         "do nothing, unsuccessfully",
>> @@ -171,3 +175,5 @@ U_BOOT_CMD(
>>         "do nothing, successfully",
>>         NULL
>>  );
>> +
>> +#endif
> 
> ... as it would completely remove the command entries if "true" was
> not defined.
> 

Right. I will go with Tom's suggestion.

York

  reply	other threads:[~2013-04-04 21:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04 17:46 [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working) Pali Rohár
2013-04-04 20:33 ` Wolfgang Denk
2013-04-04 20:34   ` York Sun
2013-04-04 21:05   ` York Sun
2013-04-04 21:19     ` Pali Rohár
2013-04-04 21:21       ` York Sun
2013-04-04 21:26         ` Pali Rohár
2013-04-04 21:31           ` York Sun
2013-04-04 21:50             ` Wolfgang Denk
2013-04-04 21:58               ` York Sun
2013-04-04 21:47         ` Wolfgang Denk
2013-04-04 21:48           ` York Sun [this message]
2013-04-04 21:37     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515DF543.7000801@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.