From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamezawa Hiroyuki Subject: Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg() Date: Fri, 05 Apr 2013 14:01:31 +0900 Message-ID: <515E5AAB.2080503@jp.fujitsu.com> References: <515BF233.6070308@huawei.com> <515BF249.50607@huawei.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <515BF249.50607-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Li Zefan Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, LKML , Cgroups , Tejun Heo , Glauber Costa , Michal Hocko , Johannes Weiner (2013/04/03 18:11), Li Zefan wrote: > Use css_get/css_put instead of mem_cgroup_get/put. > > Note, if at the same time someone is moving @current to a different > cgroup and removing the old cgroup, css_tryget() may return false, > and sock->sk_cgrp won't be initialized. > > Signed-off-by: Li Zefan Thank you. Acked-by: KAMEZAWA Hiroyuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx147.postini.com [74.125.245.147]) by kanga.kvack.org (Postfix) with SMTP id 8DF0E6B0005 for ; Fri, 5 Apr 2013 01:03:15 -0400 (EDT) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 8A0833EE0C0 for ; Fri, 5 Apr 2013 14:03:13 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 6C67645DEC0 for ; Fri, 5 Apr 2013 14:03:13 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 54A8245DEBE for ; Fri, 5 Apr 2013 14:03:13 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 490BA1DB803C for ; Fri, 5 Apr 2013 14:03:13 +0900 (JST) Received: from m1000.s.css.fujitsu.com (m1000.s.css.fujitsu.com [10.240.81.136]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id EC4CBE08003 for ; Fri, 5 Apr 2013 14:03:12 +0900 (JST) Message-ID: <515E5AAB.2080503@jp.fujitsu.com> Date: Fri, 05 Apr 2013 14:01:31 +0900 From: Kamezawa Hiroyuki MIME-Version: 1.0 Subject: Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg() References: <515BF233.6070308@huawei.com> <515BF249.50607@huawei.com> In-Reply-To: <515BF249.50607@huawei.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Li Zefan Cc: linux-mm@kvack.org, LKML , Cgroups , Tejun Heo , Glauber Costa , Michal Hocko , Johannes Weiner (2013/04/03 18:11), Li Zefan wrote: > Use css_get/css_put instead of mem_cgroup_get/put. > > Note, if at the same time someone is moving @current to a different > cgroup and removing the old cgroup, css_tryget() may return false, > and sock->sk_cgrp won't be initialized. > > Signed-off-by: Li Zefan Thank you. Acked-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161509Ab3DEFDQ (ORCPT ); Fri, 5 Apr 2013 01:03:16 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:37124 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753488Ab3DEFDP (ORCPT ); Fri, 5 Apr 2013 01:03:15 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.8.4 Message-ID: <515E5AAB.2080503@jp.fujitsu.com> Date: Fri, 05 Apr 2013 14:01:31 +0900 From: Kamezawa Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Li Zefan CC: linux-mm@kvack.org, LKML , Cgroups , Tejun Heo , Glauber Costa , Michal Hocko , Johannes Weiner Subject: Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg() References: <515BF233.6070308@huawei.com> <515BF249.50607@huawei.com> In-Reply-To: <515BF249.50607@huawei.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2013/04/03 18:11), Li Zefan wrote: > Use css_get/css_put instead of mem_cgroup_get/put. > > Note, if at the same time someone is moving @current to a different > cgroup and removing the old cgroup, css_tryget() may return false, > and sock->sk_cgrp won't be initialized. > > Signed-off-by: Li Zefan Thank you. Acked-by: KAMEZAWA Hiroyuki