From: Adam Williamson <awilliam@redhat.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: dirk.brandewie@gmail.com, Parag Warudkar <parag.lkml@gmail.com>,
rjw@sisk.pl, linux-kernel@vger.kernel.org,
cpufreq@vger.kernel.org
Subject: Re: [PATCH] cpufreq/intel_pstate: Set timer timeout correctly
Date: Thu, 04 Apr 2013 22:42:57 -0700 [thread overview]
Message-ID: <515E6461.3060800@redhat.com> (raw)
In-Reply-To: <CAOh2x=mzQBSnBB3-10yGMdGfxMWeMcvE_t2Mvnz+fvdHv0-uaA@mail.gmail.com>
On 04/04/13 10:19 PM, Viresh Kumar wrote:
> On Thu, Apr 4, 2013 at 11:05 PM, <dirk.brandewie@gmail.com> wrote:
>> From: Dirk Brandewie <dirk.brandewie@gmail.com>
>>
>> The current calculation of the delay time is wrong and a cut and paste
>> error from a previous experimental driver. This can result in the
>> timeout being set to jiffies + 1 which setup the driver to race with
>> it's self if the apic timer interrupt happen at just the right time.
>>
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=920289
>>
>> Reported-by: Adam Williamson <awilliam@redhat.com>
>> Reported-by: Parag Warudkar <parag.lkml@gmail.com>
>>
>> Signed-off-by: Dirk Brandewie <dirk.brandewie@gmail.com>
>> ---
>> drivers/cpufreq/intel_pstate.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> Looks fine, but I would like to see a Tested-by from Adam/Parag
> as they haven't said anything about this patch (even in bugzilla).
I'll try. Note the bug is not reliably reproducible, all I can really do
is run for a day or two and see if it crashes.
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | identi.ca: adamwfedora
http://www.happyassassin.net
next prev parent reply other threads:[~2013-04-05 5:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 17:35 [PATCH] cpufreq/intel_pstate: Set timer timeout correctly dirk.brandewie
2013-04-05 5:19 ` Viresh Kumar
2013-04-05 5:42 ` Adam Williamson [this message]
2013-04-05 23:46 ` Parag Warudkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515E6461.3060800@redhat.com \
--to=awilliam@redhat.com \
--cc=cpufreq@vger.kernel.org \
--cc=dirk.brandewie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=parag.lkml@gmail.com \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.