From: Wolfgang Grandegger <wg@grandegger.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>, linux-can@vger.kernel.org
Subject: Re: [RFC PATCH] can: sja1000: use common prefix for all sja1000 defines
Date: Fri, 05 Apr 2013 11:41:13 +0200 [thread overview]
Message-ID: <515E9C39.1040808@grandegger.com> (raw)
In-Reply-To: <515E84AF.303@pengutronix.de>
On 04/05/2013 10:00 AM, Marc Kleine-Budde wrote:
> On 04/03/2013 09:51 PM, Oliver Hartkopp wrote:
>> I used SJA_ as prefix for all relevant defines - even for SJA1000_ defines:
>
> I like SJA1000_ more then SJA_, but I don't insist on that... :)
Me too! A *common* prefix is nicer. If the lenght does matter I would
prefer dropping "REG_". Just the C_CAN driver uses "_REG_" as suffix.
Wolfgang.
next prev parent reply other threads:[~2013-04-05 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 7:42 [RFC PATCH] can: sja1000: use common prefix for all sja1000 defines Marc Kleine-Budde
2013-04-03 19:51 ` Oliver Hartkopp
2013-04-05 8:00 ` Marc Kleine-Budde
2013-04-05 9:41 ` Wolfgang Grandegger [this message]
2013-04-05 18:24 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515E9C39.1040808@grandegger.com \
--to=wg@grandegger.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.