All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	"Keir (Xen.org)" <keir@xen.org>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	"xen-api@lists.xen.org" <xen-api@lists.xen.org>
Subject: Re: [PATCH 2 of 5 v4] tools/libxc: Helper function for XEN_SYSCTL_consoleringsize
Date: Fri, 5 Apr 2013 15:50:41 +0100	[thread overview]
Message-ID: <515EE4C1.8000503@citrix.com> (raw)
In-Reply-To: <515EE418.1020808@citrix.com>

On 05/04/13 15:47, Andrew Cooper wrote:
> On 13/03/13 12:52, Andrew Cooper wrote:
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Keir/Jan: Ping? This is a hypervisor change.

Apologies - this is actually a tools change. Ian/Ian?

>
>> ---
>> Changes since v2:
>>  * Tweak style and errno in case of invalid pointer.
>>
>> diff -r 89f3c6846f6b -r 0bd32c19873e tools/libxc/xc_misc.c
>> --- a/tools/libxc/xc_misc.c
>> +++ b/tools/libxc/xc_misc.c
>> @@ -100,6 +100,26 @@ int xc_readconsolering(xc_interface *xch
>>      return ret;
>>  }
>>  
>> +int xc_consoleringsize(xc_interface *xch, uint64_t *psize)
>> +{
>> +    int ret = -1;
>> +    DECLARE_SYSCTL;
>> +
>> +    if ( !psize )
>> +    {
>> +        errno = EINVAL;
>> +        return ret;
>> +    }
>> +
>> +    sysctl.cmd = XEN_SYSCTL_consoleringsize;
>> +    ret = do_sysctl(xch, &sysctl);
>> +
>> +    if ( !ret )
>> +        *psize = sysctl.u.consoleringsize.size;
>> +
>> +    return ret;
>> +}
>> +
>>  int xc_send_debug_keys(xc_interface *xch, char *keys)
>>  {
>>      int ret, len = strlen(keys);
>> diff -r 89f3c6846f6b -r 0bd32c19873e tools/libxc/xenctrl.h
>> --- a/tools/libxc/xenctrl.h
>> +++ b/tools/libxc/xenctrl.h
>> @@ -998,6 +998,7 @@ int xc_readconsolering(xc_interface *xch
>>                         char *buffer,
>>                         unsigned int *pnr_chars,
>>                         int clear, int incremental, uint32_t *pindex);
>> +int xc_consoleringsize(xc_interface *xch, uint64_t *psize);
>>  
>>  int xc_send_debug_keys(xc_interface *xch, char *keys);
>>  
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

  parent reply	other threads:[~2013-04-05 14:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <patchbomb.1363179134@andrewcoop.uk.xensource.com>
2013-03-13 12:52 ` [PATCH 1 of 5 v4] common/sysctl: Introduce hypercall to query the console ring size Andrew Cooper
2013-03-13 12:52 ` [PATCH 2 of 5 v4] tools/libxc: Helper function for XEN_SYSCTL_consoleringsize Andrew Cooper
2013-03-13 12:52 ` [PATCH 3 of 5 v4] tools/libxc: Implement xc_readconsolering_buffer() Andrew Cooper
2013-03-13 12:52 ` [PATCH 4 of 5 v4] tools/ocaml: libxc bindings: Fix stub_xc_readconsolering() Andrew Cooper
2013-03-13 12:52 ` [PATCH 5 of 5 v4] tools/ocaml: libxc bindings: Fix failwith_xc() Andrew Cooper
     [not found] ` <5bd08f35b3622b4e21e8.1363179138@andrewcoop.uk.xensource.com>
2013-03-13 15:19   ` [PATCH 4 of 5 v4] tools/ocaml: libxc bindings: Fix stub_xc_readconsolering() Dave Scott
     [not found] ` <0bd32c19873e4ff55c07.1363179136@andrewcoop.uk.xensource.com>
2013-04-05 14:47   ` [PATCH 2 of 5 v4] tools/libxc: Helper function for XEN_SYSCTL_consoleringsize Andrew Cooper
     [not found]   ` <515EE418.1020808@citrix.com>
2013-04-05 14:50     ` Andrew Cooper [this message]
2013-04-11 13:18       ` Ian Campbell
     [not found] ` <89f3c6846f6b4f229e68.1363179135@andrewcoop.uk.xensource.com>
2013-04-05 14:48   ` [PATCH 1 of 5 v4] common/sysctl: Introduce hypercall to query the console ring size Andrew Cooper
     [not found]   ` <515EE44D.6070907@citrix.com>
2013-04-22 11:59     ` Ian Campbell
     [not found] ` <c7b82dfbec34f4abc049.1363179137@andrewcoop.uk.xensource.com>
2013-04-11 13:21   ` [PATCH 3 of 5 v4] tools/libxc: Implement xc_readconsolering_buffer() Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515EE4C1.8000503@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-api@lists.xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.