From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx146.postini.com [74.125.245.146]) by kanga.kvack.org (Postfix) with SMTP id 423A36B0108 for ; Fri, 5 Apr 2013 14:33:23 -0400 (EDT) Received: by mail-gh0-f170.google.com with SMTP id z2so647105ghb.29 for ; Fri, 05 Apr 2013 11:33:22 -0700 (PDT) Message-ID: <515F18F1.4050901@gmail.com> Date: Fri, 05 Apr 2013 14:33:21 -0400 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [PATCH v3 2/3] fix hugetlb memory check in vma_dump_size() References: <1365014138-19589-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1365014138-19589-3-git-send-email-n-horiguchi@ah.jp.nec.com> In-Reply-To: <1365014138-19589-3-git-send-email-n-horiguchi@ah.jp.nec.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Naoya Horiguchi Cc: Andrew Morton , Mel Gorman , Hugh Dickins , Rik van Riel , KOSAKI Motohiro , Konstantin Khlebnikov , Michal Hocko , HATAYAMA Daisuke , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kosaki.motohiro@gmail.com (4/3/13 2:35 PM), Naoya Horiguchi wrote: > Documentation/filesystems/proc.txt says about coredump_filter bitmask, > > Note bit 0-4 doesn't effect any hugetlb memory. hugetlb memory are only > effected by bit 5-6. > > However current code can go into the subsequent flag checks of bit 0-4 > for vma(VM_HUGETLB). So this patch inserts 'return' and makes it work > as written in the document. > > Signed-off-by: Naoya Horiguchi > Cc: stable@vger.kernel.org If I were you, I merge this patch into [1/3] because both patches treat the same regression. but it is no big matter. Acked-by: KOSAKI Motohiro -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162526Ab3DETB0 (ORCPT ); Fri, 5 Apr 2013 15:01:26 -0400 Received: from mail-yh0-f53.google.com ([209.85.213.53]:36464 "EHLO mail-yh0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162505Ab3DETBZ (ORCPT ); Fri, 5 Apr 2013 15:01:25 -0400 Message-ID: <515F18F1.4050901@gmail.com> Date: Fri, 05 Apr 2013 14:33:21 -0400 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Naoya Horiguchi CC: Andrew Morton , Mel Gorman , Hugh Dickins , Rik van Riel , KOSAKI Motohiro , Konstantin Khlebnikov , Michal Hocko , HATAYAMA Daisuke , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kosaki.motohiro@gmail.com Subject: Re: [PATCH v3 2/3] fix hugetlb memory check in vma_dump_size() References: <1365014138-19589-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1365014138-19589-3-git-send-email-n-horiguchi@ah.jp.nec.com> In-Reply-To: <1365014138-19589-3-git-send-email-n-horiguchi@ah.jp.nec.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (4/3/13 2:35 PM), Naoya Horiguchi wrote: > Documentation/filesystems/proc.txt says about coredump_filter bitmask, > > Note bit 0-4 doesn't effect any hugetlb memory. hugetlb memory are only > effected by bit 5-6. > > However current code can go into the subsequent flag checks of bit 0-4 > for vma(VM_HUGETLB). So this patch inserts 'return' and makes it work > as written in the document. > > Signed-off-by: Naoya Horiguchi > Cc: stable@vger.kernel.org If I were you, I merge this patch into [1/3] because both patches treat the same regression. but it is no big matter. Acked-by: KOSAKI Motohiro