From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38852)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1UOMIc-0005NL-Fc
	for qemu-devel@nongnu.org; Sat, 06 Apr 2013 02:08:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1UOMIW-0006tC-FL
	for qemu-devel@nongnu.org; Sat, 06 Apr 2013 02:08:26 -0400
Received: from isrv.corpit.ru ([86.62.121.231]:47544)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1UOMIW-0006qt-7Y
	for qemu-devel@nongnu.org; Sat, 06 Apr 2013 02:08:20 -0400
Message-ID: <515FBBC9.1020800@msgid.tls.msk.ru>
Date: Sat, 06 Apr 2013 10:08:09 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <20120110173816.GB6244@volta.aurel32.net>
In-Reply-To: <20120110173816.GB6244@volta.aurel32.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] sparc-linux-user: Fix missing symbols in
	.rel/.rela.plt sections
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

This patch was submitted more than a year ago (at Jan-2012).
Is it still needed?  If yes, why it hasn't been applied?

It still applies cleanly to the current git, with the exception
of s|^|ldscripts/| - sparc.ld moved from the top directory to
ldscripts/.

(Ref: http://patchwork.ozlabs.org/patch/135267 )

Thanks,

/mjt


10.01.2012 11:38, Aurelien Jarno wrote:
> sparc-linux-user: Fix missing symbols in .rel/.rela.plt sections
> 
> Fix .rel.plt sections in the output to not only include .rel.plt
> sections from the input but also the .rel.iplt sections and to define
> the hidden symbols __rel_iplt_start and __rel_iplt_end around
> .rel.iplt as otherwise we get undefined references to these when
> linking statically to a multiarch enabled libc (using STT_GNU_IFUNC).
> 
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> 
> ---
> sparc.ld |   16 ++++++++++++++--
>  1 files changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/sparc.ld b/sparc.ld
> index 56efe34..cec17c9 100644
> --- a/sparc.ld
> +++ b/sparc.ld
> @@ -37,8 +37,20 @@ SECTIONS
>    .rela.fini     : { *(.rela.fini)      }
>    .rel.bss       : { *(.rel.bss)                }
>    .rela.bss      : { *(.rela.bss)               }
> -  .rel.plt       : { *(.rel.plt)                }
> -  .rela.plt      : { *(.rela.plt)               }
> +  .rel.plt      :
> +  {
> +    *(.rel.plt)
> +    PROVIDE (__rel_iplt_start = .);
> +    *(.rel.iplt)
> +    PROVIDE (__rel_iplt_end = .);
> +  }
> +  .rela.plt       :
> +  {
> +    *(.rela.plt)
> +    PROVIDE (__rela_iplt_start = .);
> +    *(.rela.iplt)
> +    PROVIDE (__rela_iplt_end = .);
> +  }
>    .init          : { *(.init)   } =0x47ff041f
>    .text      :
>    {
>