From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Stornelli Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called Date: Sat, 06 Apr 2013 16:56:25 +0200 Message-ID: <51603799.9070008@gmail.com> References: <515FF344.8040705@gmail.com> <20130406131703.GC28744@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Linux FS Devel , Chris Mason , Steve French , Theodore Ts'o , Andreas Dilger , Miklos Szeredi , Alexander Viro , Anton Altaparmakov , Mark Fasheh , Joel Becker , Ben Myers , Alex Elder , xfs@oss.sgi.com, Mike Snitzer , Alasdair G Kergon , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, Jan Kara To: Matthew Wilcox Return-path: In-Reply-To: <20130406131703.GC28744@parisc-linux.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-cifs.vger.kernel.org Il 06/04/2013 15:17, Matthew Wilcox ha scritto: > On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: >> In every place where sb_start_write was called now we must manage >> the error code and return -EINTR. > > If we must manage the error code, then these functions should be marked > __must_check. > Yep, good point. Marco From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 612DE7F94 for ; Sat, 6 Apr 2013 10:03:42 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id E56DEAC003 for ; Sat, 6 Apr 2013 08:03:38 -0700 (PDT) Received: from mail-ee0-f48.google.com (mail-ee0-f48.google.com [74.125.83.48]) by cuda.sgi.com with ESMTP id PPk1L4RB381oZILf (version=TLSv1 cipher=RC4-SHA bits=128 verify=NO) for ; Sat, 06 Apr 2013 08:03:37 -0700 (PDT) Received: by mail-ee0-f48.google.com with SMTP id b15so1759715eek.21 for ; Sat, 06 Apr 2013 08:03:36 -0700 (PDT) Message-ID: <51603799.9070008@gmail.com> Date: Sat, 06 Apr 2013 16:56:25 +0200 From: Marco Stornelli MIME-Version: 1.0 Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called References: <515FF344.8040705@gmail.com> <20130406131703.GC28744@parisc-linux.org> In-Reply-To: <20130406131703.GC28744@parisc-linux.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Matthew Wilcox Cc: Chris Mason , Jan Kara , Mike Snitzer , linux-mm@kvack.org, Andreas Dilger , Alasdair G Kergon , linux-cifs@vger.kernel.org, Miklos Szeredi , linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net, Mark Fasheh , xfs@oss.sgi.com, Ben Myers , Alexander Viro , Anton Altaparmakov , Alex Elder , Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Steve French , ocfs2-devel@oss.oracle.com, Linux FS Devel , linux-btrfs@vger.kernel.org, Joel Becker Il 06/04/2013 15:17, Matthew Wilcox ha scritto: > On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: >> In every place where sb_start_write was called now we must manage >> the error code and return -EINTR. > > If we must manage the error code, then these functions should be marked > __must_check. > Yep, good point. Marco _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Stornelli Date: Sat, 06 Apr 2013 15:03:45 -0000 Subject: [Ocfs2-devel] [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called In-Reply-To: <20130406131703.GC28744@parisc-linux.org> References: <515FF344.8040705@gmail.com> <20130406131703.GC28744@parisc-linux.org> Message-ID: <51603799.9070008@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Wilcox Cc: Linux FS Devel , Chris Mason , Steve French , Theodore Ts'o , Andreas Dilger , Miklos Szeredi , Alexander Viro , Anton Altaparmakov , Mark Fasheh , Joel Becker , Ben Myers , Alex Elder , xfs@oss.sgi.com, Mike Snitzer , Alasdair G Kergon , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, Jan Kara Il 06/04/2013 15:17, Matthew Wilcox ha scritto: > On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: >> In every place where sb_start_write was called now we must manage >> the error code and return -EINTR. > > If we must manage the error code, then these functions should be marked > __must_check. > Yep, good point. Marco From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx143.postini.com [74.125.245.143]) by kanga.kvack.org (Postfix) with SMTP id 066536B01AA for ; Sat, 6 Apr 2013 11:03:37 -0400 (EDT) Received: by mail-ee0-f51.google.com with SMTP id c4so1691276eek.10 for ; Sat, 06 Apr 2013 08:03:36 -0700 (PDT) Message-ID: <51603799.9070008@gmail.com> Date: Sat, 06 Apr 2013 16:56:25 +0200 From: Marco Stornelli MIME-Version: 1.0 Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called References: <515FF344.8040705@gmail.com> <20130406131703.GC28744@parisc-linux.org> In-Reply-To: <20130406131703.GC28744@parisc-linux.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Matthew Wilcox Cc: Linux FS Devel , Chris Mason , Steve French , Theodore Ts'o , Andreas Dilger , Miklos Szeredi , Alexander Viro , Anton Altaparmakov , Mark Fasheh , Joel Becker , Ben Myers , Alex Elder , xfs@oss.sgi.com, Mike Snitzer , Alasdair G Kergon , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, Jan Kara Il 06/04/2013 15:17, Matthew Wilcox ha scritto: > On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: >> In every place where sb_start_write was called now we must manage >> the error code and return -EINTR. > > If we must manage the error code, then these functions should be marked > __must_check. > Yep, good point. Marco -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org