All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jussi Laako <jussi@sonarnerd.net>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de, clemens@ladisch.de,
	demian@auraliti.com, ray@auraliti.com, andreas@akdesigninc.com
Subject: Re: [PATCH 1/2] ALSA: add DSD formats
Date: Sat, 06 Apr 2013 20:53:52 +0300	[thread overview]
Message-ID: <51606130.1080208@sonarnerd.net> (raw)
In-Reply-To: <1365248693-27867-1-git-send-email-zonque@gmail.com>

On 04/06/2013 02:44 PM, Daniel Mack wrote:
> +#define SNDRV_PCM_FMTBIT_DSD_DOP_U8	_SNDRV_PCM_FMTBIT(DSD_DOP_U8)
> +#define SNDRV_PCM_FMTBIT_DSD_DOP_U16	_SNDRV_PCM_FMTBIT(DSD_DOP_U16)

No, this is not good, DoP always has the 8-bit marker in the MSB and has 
to be either 24-bit or longer word. One byte marker and two bytes of 
payload, padded with one byte of zeros if payload is 32-bit dword.

  parent reply	other threads:[~2013-04-06 17:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-06 11:44 [PATCH 1/2] ALSA: add DSD formats Daniel Mack
2013-04-06 11:44 ` [PATCH 2/2] ALSA: snd-usb: add quirks handler for DSD streams Daniel Mack
2013-04-06 11:44 ` Daniel Mack
2013-04-06 11:48   ` Daniel Mack
2013-04-06 17:53 ` Jussi Laako [this message]
2013-04-06 17:59   ` [PATCH 1/2] ALSA: add DSD formats Daniel Mack
2013-04-06 21:56     ` Jussi Laako
2013-04-06 23:07 ` Jussi Laako
2013-04-07  7:35 ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2013-03-27 23:30 Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51606130.1080208@sonarnerd.net \
    --to=jussi@sonarnerd.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=andreas@akdesigninc.com \
    --cc=clemens@ladisch.de \
    --cc=demian@auraliti.com \
    --cc=ray@auraliti.com \
    --cc=tiwai@suse.de \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.