From: WANG Chao <chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Cong Wang <amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
jpirko-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ifup.sh: Add support for bridge over team and vlan tagged team
Date: Sun, 07 Apr 2013 17:32:00 +0800 [thread overview]
Message-ID: <51613D10.7040101@redhat.com> (raw)
In-Reply-To: <1365326401.7049.0.camel@cr0>
On 04/07/2013 05:20 PM, Cong Wang wrote:
> On Mon, 2013-04-01 at 20:34 +0800, WANG Chao wrote:
>> Team is the same network stack as bonding. Therefore give ifup the ability to
>> handle bridge over team and vlan tagged team as bonding too.
>>
>
> Looks good to me.
>
> Next time please mention how you test the patch in the changelog, it
> helps too.
Thanks for review.
I thought this patch is quite straightforward so I didn't mention the tests.
I'll bring it up next time. Thanks!
WANG Chao
next prev parent reply other threads:[~2013-04-07 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 12:34 [PATCH] ifup.sh: Add support for bridge over team and vlan tagged team WANG Chao
[not found] ` <1364819680-1618-1-git-send-email-chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-07 6:47 ` WANG Chao
2013-04-07 9:20 ` Cong Wang
2013-04-07 9:32 ` WANG Chao [this message]
2013-04-09 8:53 ` Harald Hoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51613D10.7040101@redhat.com \
--to=chaowang-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jpirko-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.