From: Chen Gang <gang.chen@asianux.com>
To: jason.wessel@windriver.com
Cc: kgdb-bugreport@lists.sourceforge.net,
"linux-kernel@vger.kernel.org >>
\"linux-kernel@vger.kernel.org\"" <linux-kernel@vger.kernel.org>
Subject: [PATCH] kernel: debug: kdb: strncpy issue, using strlcpy instead of strncpy
Date: Sun, 07 Apr 2013 19:20:50 +0800 [thread overview]
Message-ID: <51615692.2010906@asianux.com> (raw)
kdb_prompt_str is NUL terminated string, need always set '\0' at the end.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
kernel/debug/kdb/kdb_io.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index 14ff484..932b436 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -442,7 +442,7 @@ poll_again:
char *kdb_getstr(char *buffer, size_t bufsize, char *prompt)
{
if (prompt && kdb_prompt_str != prompt)
- strncpy(kdb_prompt_str, prompt, CMD_BUFLEN);
+ strlcpy(kdb_prompt_str, prompt, CMD_BUFLEN);
kdb_printf(kdb_prompt_str);
kdb_nextline = 1; /* Prompt and input resets line number */
return kdb_read(buffer, bufsize);
--
1.7.7.6
next reply other threads:[~2013-04-07 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 11:20 Chen Gang [this message]
2013-04-17 9:43 ` [PATCH] kernel: debug: kdb: strncpy issue, using strlcpy instead of strncpy Chen Gang
-- strict thread matches above, loose matches on Subject: below --
2013-05-16 11:38 Chen Gang
2013-04-07 11:03 Chen Gang
2013-04-17 9:43 ` Chen Gang
2013-04-23 20:50 ` Anton Vorontsov
2013-04-24 1:12 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51615692.2010906@asianux.com \
--to=gang.chen@asianux.com \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.