From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, amirv@mellanox.com,
sagig@mellanox.com, john.r.fastabend@intel.com
Subject: Re: [PATCH V1 net-next 3/3] net/mlx4_en: Advertize DCB_CAP_DCBX_HOST in getdcbx
Date: Sun, 07 Apr 2013 19:31:27 +0400 [thread overview]
Message-ID: <5161914F.8020801@cogentembedded.com> (raw)
In-Reply-To: <1365342248-31901-4-git-send-email-ogerlitz@mellanox.com>
Hello.
On 07-04-2013 17:44, Or Gerlitz wrote:
> When our getdcbx entry is called, DCB_CAP_DCBX_HOST should be advertized too.
> Cc: John Fastabend <john.r.fastabend@intel.com>
> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
[...]
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c b/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
> index 321553f..9199aed 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
> @@ -186,7 +186,7 @@ static int mlx4_en_dcbnl_ieee_setpfc(struct net_device *dev,
>
> static u8 mlx4_en_dcbnl_getdcbx(struct net_device *dev)
> {
> - return DCB_CAP_DCBX_VER_IEEE;
> + return (DCB_CAP_DCBX_HOST | DCB_CAP_DCBX_VER_IEEE);
Nit: parens not needed here.
WBR, Sergei
next prev parent reply other threads:[~2013-04-07 15:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 13:44 [PATCH V1 net-next 0/3] Mellanox Core and Ethernet driver updates 2013-04-07 Or Gerlitz
2013-04-07 13:44 ` [PATCH V1 net-next 1/3] net/mlx4_core: Added proper description for two device capabilities Or Gerlitz
2013-04-07 13:44 ` [PATCH V1 net-next 2/3] net/mlx4_en: Enable DCB ETS ops only when supported by the firmware Or Gerlitz
2013-04-07 13:44 ` [PATCH V1 net-next 3/3] net/mlx4_en: Advertize DCB_CAP_DCBX_HOST in getdcbx Or Gerlitz
2013-04-07 15:31 ` Sergei Shtylyov [this message]
2013-04-07 20:56 ` David Miller
2013-04-07 20:56 ` [PATCH V1 net-next 0/3] Mellanox Core and Ethernet driver updates 2013-04-07 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5161914F.8020801@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=sagig@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.