From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936240Ab3DHKGG (ORCPT ); Mon, 8 Apr 2013 06:06:06 -0400 Received: from www.linutronix.de ([62.245.132.108]:33971 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964907Ab3DHKGD (ORCPT ); Mon, 8 Apr 2013 06:06:03 -0400 Message-ID: <51629686.7030708@linutronix.de> Date: Mon, 08 Apr 2013 12:05:58 +0200 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Lai Jiangshan CC: "Paul E. McKenney" , linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [PATCH 1/3] kernel/srcu: merge common code into a macro References: <1363702606-31586-1-git-send-email-bigeasy@linutronix.de> <515E7B77.7010807@cn.fujitsu.com> In-Reply-To: <515E7B77.7010807@cn.fujitsu.com> X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05/2013 09:21 AM, Lai Jiangshan wrote: > Hi, Sebastian Hi Lai, > The patch hurts readability. > The original code are simple enough, merging them as one macro > gives us no benefit. Except when you need to adjust the macro and you have to touch both of them instead just one. But I don't have strong feelings for that one. > Thanks > Lai. Sebastian