From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Magnus Gille <mgille@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Make sure GRED backlog does not get screwed up.
Date: Mon, 08 Apr 2013 06:26:44 -0400 [thread overview]
Message-ID: <51629B64.2020406@mojatatu.com> (raw)
In-Reply-To: <CAD-Y_xtAvq5+mVe-=VDCDntY-NE2Oq+mhv56g6d8Tb2uiHw6bw@mail.gmail.com>
Hi,
please use my proper address (in the From:) for faster response.
On 13-04-02 02:32 PM, Magnus Gille wrote:
> First patch, comments, feedback, suggestions are welcome. Before this patch
> we could end up with a 4GB backlog on certain DPs without any packets. The
> patch is created against net-next.
>
> If a packet is enqueued on a GRED qdisc before the DPs are setup the packet
> will not be accounted for in the DP backlog queue.
In such a case, the packet will end up in the default queue
> When the packet later
> gets
> dequeued from the DP queue it will subtract the length from the DP backlog
> but,
> since the packet was never accounted for we now wrap the backlog around.
> Fixed
> this by making sure we never subtract more than what's present in the
> backlog.
When no DPs set: if the packet was enqueued in a default queue,
at dequeue it will be pulled from the default queue.
What am i missing?
cheers,
jamal
parent reply other threads:[~2013-04-08 10:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAD-Y_xtAvq5+mVe-=VDCDntY-NE2Oq+mhv56g6d8Tb2uiHw6bw@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51629B64.2020406@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=mgille@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.