All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mart Frauenlob <mart.frauenlob@chello.at>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH] iptables manpage: Update protocol list for MASQUERADE and REDIRECT
Date: Mon, 08 Apr 2013 13:30:30 +0200	[thread overview]
Message-ID: <5162AA56.70008@chello.at> (raw)

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Hello,

this patch updates the list of protocols valid for the --to-ports option 
of the MASQUERADE and REDIRECT targets.

If I read the source correctly (no C programmer), icmp is also valid.
In that case the error message for !portok is missing icmp.

What does one specify, what is mapped with --to-ports and -p icmp?

Best regards

Mart

P.S. Is it ok to base on master, or should I use stable/next?

[-- Attachment #2: manpage-Update-protocol-list-for-MASQUERADE-and-REDIRECT.patch --]
[-- Type: text/plain, Size: 2324 bytes --]

>From 8e78fab467dbca6d1e27218cc4db091545a49027 Mon Sep 17 00:00:00 2001
From: Mart Frauenlob <mart.frauenlob@chello.at>
Date: Mon, 8 Apr 2013 13:11:49 +0200
Subject: [PATCH] manpage: Update protocol list for MASQUERADE and REDIRET.

---
 extensions/libip6t_MASQUERADE.man |    6 +++---
 extensions/libipt_MASQUERADE.man  |    6 +++---
 extensions/libipt_REDIRECT.man    |    6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/extensions/libip6t_MASQUERADE.man b/extensions/libip6t_MASQUERADE.man
index c63d826..b5b7677 100644
--- a/extensions/libip6t_MASQUERADE.man
+++ b/extensions/libip6t_MASQUERADE.man
@@ -16,10 +16,10 @@ any established connections are lost anyway).
 This specifies a range of source ports to use, overriding the default
 .B SNAT
 source port-selection heuristics (see above).  This is only valid
-if the rule also specifies
-\fB\-p tcp\fP
+if the rule also specifies one of the following protocols:
+.B tcp, udp, dccp, sctp
 or
-\fB\-p udp\fP.
+.B icmp.
 .TP
 \fB\-\-random\fP
 Randomize source port mapping
diff --git a/extensions/libipt_MASQUERADE.man b/extensions/libipt_MASQUERADE.man
index 2dae964..807ddbd 100644
--- a/extensions/libipt_MASQUERADE.man
+++ b/extensions/libipt_MASQUERADE.man
@@ -16,10 +16,10 @@ any established connections are lost anyway).
 This specifies a range of source ports to use, overriding the default
 .B SNAT
 source port-selection heuristics (see above).  This is only valid
-if the rule also specifies
-\fB\-p tcp\fP
+if the rule also specifies one of the following protocols:
+.B tcp, udp, dccp, sctp
 or
-\fB\-p udp\fP.
+.B icmp.
 .TP
 \fB\-\-random\fP
 Randomize source port mapping
diff --git a/extensions/libipt_REDIRECT.man b/extensions/libipt_REDIRECT.man
index 90ab19d..635ddd4 100644
--- a/extensions/libipt_REDIRECT.man
+++ b/extensions/libipt_REDIRECT.man
@@ -12,10 +12,10 @@ destination IP to the primary address of the incoming interface
 \fB\-\-to\-ports\fP \fIport\fP[\fB\-\fP\fIport\fP]
 This specifies a destination port or range of ports to use: without
 this, the destination port is never altered.  This is only valid
-if the rule also specifies
-\fB\-p tcp\fP
+if the rule also specifies one of the following protocols:
+.B tcp, udp, dccp, sctp
 or
-\fB\-p udp\fP.
+.B icmp.
 .TP
 \fB\-\-random\fP
 If option
-- 
1.7.2.5


                 reply	other threads:[~2013-04-08 11:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5162AA56.70008@chello.at \
    --to=mart.frauenlob@chello.at \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.