All of lore.kernel.org
 help / color / mirror / Atom feed
From: Serban Constantinescu <Serban.Constantinescu@arm.com>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Android Kernel Team <kernel-team@android.com>,
	John Stultz <john.stultz@linaro.org>,
	Dave Butcher <Dave.Butcher@arm.com>
Subject: Re: [PATCH 0/8] Android Binder IPC Fixes
Date: Mon, 08 Apr 2013 14:12:49 +0100	[thread overview]
Message-ID: <5162C251.7060606@arm.com> (raw)
In-Reply-To: <CAMP5Xgeh-5nLY1CLBOma2jNcS7J2tMMCkZO8Jg-_W0vCke4zmw@mail.gmail.com>

On 06/04/13 00:38, Arve Hjønnevåg wrote:
> On Fri, Apr 5, 2013 at 3:00 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> On Thu, Apr 04, 2013 at 01:32:30PM +0100, Serban Constantinescu wrote:
>>> Hi all,
>>>
>>> This set of patches will clean-up and fix some of the issues that arise
>>> with the current binder interface when moving to a 64bit kernel. All these
>>> changes will not affect the existing 32bit Android interface and are meant
>>> to stand as the base for the 64bit binder compat layer.
>>>
>>> This patch set has been successfully tested on 32bit platforms(ARMv7 VExpress)
>>> and 64bit platforms(ARMv8 RTSM) running a 32bit Android userspace and an in
>>> kernel binder compat layer.
>>
>> I need some acks from some of the Android developers before I can take
>> this.
>>
>
> I still think it is better to change user-space to use 64 bit pointer
> types when running on a 64 bit kernel. These changes do not seem to
> allow 64 bit user-space processes on a 64 bit kernel.

This patch set is independent of whether the binder compat layer lives 
in the kernel or in the userspace. However we need these changes so that 
the same kernel driver supports calls from 32bit userspace and calls 
from 64bit userspace(from the binder kernel driver perspective same as 
64bit kernel/32bit userspace with the compat layer expanding pointers 
and structures to 64bit in the userspace).

We have tested 64/64 functionality using a 64bit Linux filesystem and 
64bit binder unit tests. All tests passed for both kernel/filesystem 
configurations supported by this patch set - 32/32 and 64/64.

Thanks for your feedback,
Serban


      reply	other threads:[~2013-04-08 13:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04 12:32 [PATCH 0/8] Android Binder IPC Fixes Serban Constantinescu
2013-04-04 12:32 ` [PATCH 1/8] staging: android: binder: replace explicit size types Serban Constantinescu
2013-04-05 23:17   ` Arve Hjønnevåg
2013-04-06  6:00     ` Greg KH
2013-04-08 12:25       ` Serban Constantinescu
2013-04-08 15:20         ` Greg KH
2013-04-04 12:32 ` [PATCH 2/8] staging: android: binder: replace IOCTL types with user-exportable types Serban Constantinescu
2013-04-04 12:32 ` [PATCH 3/8] staging: android: binder: fix binder interface for 64bit compat layer Serban Constantinescu
2013-04-04 12:32 ` [PATCH 4/8] staging: android: binder: fix printk() format specifier Serban Constantinescu
2013-04-06  6:01   ` Greg KH
2013-04-04 12:32 ` [PATCH 5/8] staging: android: binder: fix BINDER_SET_MAX_THREADS declaration Serban Constantinescu
2013-04-04 12:32 ` [PATCH 6/8] staging: android: binder: fix BC_FREE_BUFFER ioctl declaration Serban Constantinescu
2013-04-04 12:32 ` [PATCH 7/8] staging: android: binder: fix alignment issues Serban Constantinescu
2013-04-04 12:32 ` [PATCH 8/8] staging: android: binder: replace types with portable ones Serban Constantinescu
2013-04-05 22:00 ` [PATCH 0/8] Android Binder IPC Fixes Greg KH
2013-04-05 23:38   ` Arve Hjønnevåg
2013-04-08 13:12     ` Serban Constantinescu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5162C251.7060606@arm.com \
    --to=serban.constantinescu@arm.com \
    --cc=Dave.Butcher@arm.com \
    --cc=arve@android.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.