From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= Subject: Re: [Qemu-devel] [PATCH uq/master v2 1/2] kvm: reset state from the CPU's reset method Date: Mon, 08 Apr 2013 16:36:47 +0200 Message-ID: <5162D5FF.8040800@suse.de> References: <1363984637-18132-1-git-send-email-pbonzini@redhat.com> <1363984637-18132-2-git-send-email-pbonzini@redhat.com> <20130402132932.GF3889@redhat.com> <20130408121950.GA9425@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org, Alexander Graf To: Gleb Natapov , Paolo Bonzini Return-path: Received: from cantor2.suse.de ([195.135.220.15]:34395 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964984Ab3DHOgt (ORCPT ); Mon, 8 Apr 2013 10:36:49 -0400 In-Reply-To: <20130408121950.GA9425@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 08.04.2013 14:19, schrieb Gleb Natapov: > On Tue, Apr 02, 2013 at 04:29:32PM +0300, Gleb Natapov wrote: >>> static void kvm_sw_tlb_put(PowerPCCPU *cpu) >>> { >>> CPUPPCState *env =3D &cpu->env; >>> diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c >>> index 23fe51f..6321384 100644 >>> --- a/target-s390x/cpu.c >>> +++ b/target-s390x/cpu.c >>> @@ -84,6 +84,10 @@ static void s390_cpu_reset(CPUState *s) >>> * after incrementing the cpu counter */ >>> #if !defined(CONFIG_USER_ONLY) >>> s->halted =3D 1; >>> + >>> + if (kvm_enabled()) { >>> + kvm_arch_reset_vcpu(s); >> Does this compile with kvm support disabled? >> > Well, it does not: > CC s390x-softmmu/target-s390x/cpu.o > /users/gleb/work/qemu/target-s390x/cpu.c: In function 's390_cpu_reset= ': > /users/gleb/work/qemu/target-s390x/cpu.c:89:9: error: implicit > declaration of function 'kvm_arch_reset_vcpu' > [-Werror=3Dimplicit-function-declaration] > /users/gleb/work/qemu/target-s390x/cpu.c:89:9: error: nested extern > declaration of 'kvm_arch_reset_vcpu' [-Werror=3Dnested-externs] > cc1: all warnings being treated as errors >=20 > I wonder if it is portable between compilers to rely on code in if(0)= {} to > be dropped in all levels of optimizations. No, we had a previous case where --enable-debug broke if (kvm_enabled()= ) {...} but regular builds worked. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg