From: Gabriel de Perthuis <g2p.code-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Kent Overstreet <koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] bcache: Take data offset from the bdev superblock.
Date: Mon, 08 Apr 2013 23:44:43 +0200 [thread overview]
Message-ID: <51633A4B.1040908@gmail.com> (raw)
In-Reply-To: <5163356F.50406-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> As for BCACHE_SB_VERSION_CDEV_WITH_UUID, can you explain why you added
>> that? I suspect it's needed but I can't remember why I didn't add it
>> when I added the new UUID format (or perhaps I just forgot)
>
> I took the name from a comment in the kernel-side bcache.h.
> BCACHE_SB_VERSION_CDEV is the version make-bcache writes, and
> BCACHE_SB_VERSION_CDEV_WITH_UUID is what the kernel updates it too; I
> just changed the version names so that user-side and kernel-side were
> more consistent, internally and with each other.
> The kernel doesn't discriminate these two versions when opening, so it
> should be possible to define only the latter and deprecate the other.
To be more clear, I've replaced the kernel's BCACHE_SB_VERSION by
BCACHE_SB_VERSION_CDEV_WITH_UUID or BCACHE_SB_MAX_VERSION depending on
the intent.
WARNING: multiple messages have this Message-ID (diff)
From: Gabriel de Perthuis <g2p.code@gmail.com>
To: Kent Overstreet <koverstreet@google.com>
Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcache: Take data offset from the bdev superblock.
Date: Mon, 08 Apr 2013 23:44:43 +0200 [thread overview]
Message-ID: <51633A4B.1040908@gmail.com> (raw)
In-Reply-To: <5163356F.50406@gmail.com>
>> As for BCACHE_SB_VERSION_CDEV_WITH_UUID, can you explain why you added
>> that? I suspect it's needed but I can't remember why I didn't add it
>> when I added the new UUID format (or perhaps I just forgot)
>
> I took the name from a comment in the kernel-side bcache.h.
> BCACHE_SB_VERSION_CDEV is the version make-bcache writes, and
> BCACHE_SB_VERSION_CDEV_WITH_UUID is what the kernel updates it too; I
> just changed the version names so that user-side and kernel-side were
> more consistent, internally and with each other.
> The kernel doesn't discriminate these two versions when opening, so it
> should be possible to define only the latter and deprecate the other.
To be more clear, I've replaced the kernel's BCACHE_SB_VERSION by
BCACHE_SB_VERSION_CDEV_WITH_UUID or BCACHE_SB_MAX_VERSION depending on
the intent.
next prev parent reply other threads:[~2013-04-08 21:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 10:09 [Pull request] bcache data offset Gabriel de Perthuis
2013-04-08 10:09 ` Gabriel de Perthuis
[not found] ` <51629766.6030805-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-08 10:11 ` [PATCH] bcache: Take data offset from the bdev superblock Gabriel
2013-04-08 10:11 ` Gabriel
[not found] ` <1365415866-16344-1-git-send-email-g2p.code+bcache-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-08 20:49 ` Kent Overstreet
2013-04-08 20:49 ` Kent Overstreet
2013-04-08 21:23 ` Gabriel
[not found] ` <5163356F.50406-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-08 21:44 ` Gabriel de Perthuis [this message]
2013-04-08 21:44 ` Gabriel de Perthuis
-- strict thread matches above, loose matches on Subject: below --
2013-04-08 8:49 [Pull request] bcache data offset Gabriel de Perthuis
[not found] ` <516284B1.7060307-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-08 8:51 ` [PATCH] bcache: Take data offset from the bdev superblock Gabriel
2013-04-08 8:51 ` Gabriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51633A4B.1040908@gmail.com \
--to=g2p.code-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.