From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 08 Apr 2013 22:08:12 +0000 Subject: Re: [PATCH v2 2/9] ehci-platform: add pre_setup() method to platform data Message-Id: <51633FCC.4090905@cogentembedded.com> List-Id: References: <201304090120.00626.sergei.shtylyov@cogentembedded.com> In-Reply-To: <201304090120.00626.sergei.shtylyov@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hello. On 04/09/2013 02:07 AM, Greg KH wrote: >>>> Sometimes there is a need to initialize some non-standard registers mapped to >>>> the EHCI region before accessing the standard EHCI registers. Add pre_setup() >>>> method with 'struct usb_hcd *' parameter to be called just before ehci_setup() >>>> to the 'ehci-platform' driver's platform data for this purpose... >>>> >>>> Suggested-by: Alan Stern >>>> Signed-off-by: Sergei Shtylyov >>>> >> [...] >>>> Index: renesas/include/linux/usb/ehci_pdriver.h >>>> =================================>>>> --- renesas.orig/include/linux/usb/ehci_pdriver.h >>>> +++ renesas/include/linux/usb/ehci_pdriver.h >>>> @@ -19,6 +19,8 @@ >>>> #ifndef __USB_CORE_EHCI_PDRIVER_H >>>> #define __USB_CORE_EHCI_PDRIVER_H >>>> +#include >>> This isn't needed in the .h file, right? Only the .c file, if it hasn't >>> already included it (hint, I bet it has...) >> No, it hasn't. And I wouldn't want to include this header in the >> platform code. > Then you don't need it in this .h file either, please remove it. I do need it in the platform .c file. Well, long live multiple redeclarations of the same thing! > thanks, > > greg k-h WBR, Sergei