From: Josh Durgin <josh.durgin@inktank.com>
To: Alex Elder <elder@inktank.com>
Cc: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH 1/6] libceph: record bio length
Date: Mon, 08 Apr 2013 16:58:07 -0700 [thread overview]
Message-ID: <5163598F.5060902@inktank.com> (raw)
In-Reply-To: <515F4F56.3000905@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
On 04/05/2013 03:25 PM, Alex Elder wrote:
> The bio is the only data item type that doesn't record its full
> length. Fix that.
>
> Signed-off-by: Alex Elder <elder@inktank.com>
> ---
> include/linux/ceph/messenger.h | 5 ++++-
> net/ceph/messenger.c | 1 +
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/ceph/messenger.h b/include/linux/ceph/messenger.h
> index cdeebae..4fb870a 100644
> --- a/include/linux/ceph/messenger.h
> +++ b/include/linux/ceph/messenger.h
> @@ -116,7 +116,10 @@ struct ceph_msg_data {
> enum ceph_msg_data_type type;
> union {
> #ifdef CONFIG_BLOCK
> - struct bio *bio;
> + struct {
> + struct bio *bio;
> + size_t bio_length;
> + };
> #endif /* CONFIG_BLOCK */
> struct {
> struct page **pages; /* NOT OWNER. */
> diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
> index ae825e44..9571d03 100644
> --- a/net/ceph/messenger.c
> +++ b/net/ceph/messenger.c
> @@ -3030,6 +3030,7 @@ void ceph_msg_data_set_bio(struct ceph_msg *msg,
> struct bio *bio,
> data = ceph_msg_data_create(CEPH_MSG_DATA_BIO);
> BUG_ON(!data);
> data->bio = bio;
> + data->bio_length = length;
>
> msg->data = data;
> msg->data_length = length;
>
next prev parent reply other threads:[~2013-04-08 23:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 22:24 [PATCH 0/6] Alex Elder
2013-04-05 22:25 ` [PATCH 1/6] libceph: record bio length Alex Elder
2013-04-08 23:58 ` Josh Durgin [this message]
2013-04-05 22:25 ` [PATCH 2/6] libceph: move cursor into message Alex Elder
2013-04-08 23:58 ` Josh Durgin
2013-04-05 22:25 ` [PATCH 3/6] libceph: have cursor point to data Alex Elder
2013-04-08 23:58 ` Josh Durgin
2013-04-05 22:26 ` [PATCH 4/6] libceph: replace message data pointer with list Alex Elder
2013-04-09 0:04 ` Josh Durgin
2013-04-05 22:26 ` [PATCH 5/6] libceph: implement multiple data items in a message Alex Elder
2013-04-05 23:36 ` [PATCH 5/6, v2] " Alex Elder
2013-04-08 23:48 ` [PATCH 5/6, v3] " Alex Elder
2013-04-09 0:27 ` Josh Durgin
2013-04-05 22:26 ` [PATCH 6/6] libceph: add, don't set data for " Alex Elder
2013-04-09 0:11 ` Josh Durgin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163598F.5060902@inktank.com \
--to=josh.durgin@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.