From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamezawa Hiroyuki Subject: Re: [PATCH 03/12] Revert "memcg: avoid dangling reference count in creation failure." Date: Tue, 09 Apr 2013 11:50:05 +0900 Message-ID: <516381DD.8050706@jp.fujitsu.com> References: <5162648B.9070802@huawei.com> <516264BF.2020009@huawei.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <516264BF.2020009@huawei.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Li Zefan Cc: Andrew Morton , Tejun Heo , Glauber Costa , Johannes Weiner , LKML , Cgroups , linux-mm@kvack.org (2013/04/08 15:33), Li Zefan wrote: > From: Michal Hocko > > This reverts commit e4715f01be697a3730c78f8ffffb595591d6a88c > > mem_cgroup_put is hierarchy aware so mem_cgroup_put(memcg) already drops > an additional reference from all parents so the additional > mem_cgrroup_put(parent) potentially causes use-after-free. > > Signed-off-by: Li Zefan > Signed-off-by: Michal Hocko Acked-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936726Ab3DICu2 (ORCPT ); Mon, 8 Apr 2013 22:50:28 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:60485 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934585Ab3DICu1 (ORCPT ); Mon, 8 Apr 2013 22:50:27 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.8.4 Message-ID: <516381DD.8050706@jp.fujitsu.com> Date: Tue, 09 Apr 2013 11:50:05 +0900 From: Kamezawa Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Li Zefan CC: Andrew Morton , Tejun Heo , Glauber Costa , Johannes Weiner , LKML , Cgroups , linux-mm@kvack.org Subject: Re: [PATCH 03/12] Revert "memcg: avoid dangling reference count in creation failure." References: <5162648B.9070802@huawei.com> <516264BF.2020009@huawei.com> In-Reply-To: <516264BF.2020009@huawei.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2013/04/08 15:33), Li Zefan wrote: > From: Michal Hocko > > This reverts commit e4715f01be697a3730c78f8ffffb595591d6a88c > > mem_cgroup_put is hierarchy aware so mem_cgroup_put(memcg) already drops > an additional reference from all parents so the additional > mem_cgrroup_put(parent) potentially causes use-after-free. > > Signed-off-by: Li Zefan > Signed-off-by: Michal Hocko Acked-by: KAMEZAWA Hiroyuki