From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamezawa Hiroyuki Subject: Re: [PATCH 12/12] memcg: don't need to free memcg via RCU or workqueue Date: Tue, 09 Apr 2013 11:57:49 +0900 Message-ID: <516383AD.9010305@jp.fujitsu.com> References: <5162648B.9070802@huawei.com> <51626570.8000400@huawei.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51626570.8000400-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Li Zefan Cc: Andrew Morton , Tejun Heo , Glauber Costa , Johannes Weiner , LKML , Cgroups , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Hugh Dickins (2013/04/08 15:36), Li Zefan wrote: > Now memcg has the same life cycle with its corresponding cgroup, and > a cgroup is freed via RCU and then mem_cgroup_css_free() is called > in a work function, so we can simply call __mem_cgroup_free() in > mem_cgroup_css_free(). > > This actually reverts 59927fb984de1703c67bc640c3e522d8b5276c73 > ("memcg: free mem_cgroup by RCU to fix oops"). > > Cc: Hugh Dickins > Signed-off-by: Li Zefan Very nice. Acked-by: KAMEZAWA Hiroyuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx153.postini.com [74.125.245.153]) by kanga.kvack.org (Postfix) with SMTP id 4377A6B0005 for ; Mon, 8 Apr 2013 22:58:11 -0400 (EDT) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 7B92F3EE0BC for ; Tue, 9 Apr 2013 11:58:09 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 5474145DEBB for ; Tue, 9 Apr 2013 11:58:09 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 14C6A45DEB6 for ; Tue, 9 Apr 2013 11:58:09 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 02B061DB803E for ; Tue, 9 Apr 2013 11:58:09 +0900 (JST) Received: from m1001.s.css.fujitsu.com (m1001.s.css.fujitsu.com [10.240.81.139]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id A4C1C1DB803C for ; Tue, 9 Apr 2013 11:58:08 +0900 (JST) Message-ID: <516383AD.9010305@jp.fujitsu.com> Date: Tue, 09 Apr 2013 11:57:49 +0900 From: Kamezawa Hiroyuki MIME-Version: 1.0 Subject: Re: [PATCH 12/12] memcg: don't need to free memcg via RCU or workqueue References: <5162648B.9070802@huawei.com> <51626570.8000400@huawei.com> In-Reply-To: <51626570.8000400@huawei.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Li Zefan Cc: Andrew Morton , Tejun Heo , Glauber Costa , Johannes Weiner , LKML , Cgroups , linux-mm@kvack.org, Hugh Dickins (2013/04/08 15:36), Li Zefan wrote: > Now memcg has the same life cycle with its corresponding cgroup, and > a cgroup is freed via RCU and then mem_cgroup_css_free() is called > in a work function, so we can simply call __mem_cgroup_free() in > mem_cgroup_css_free(). > > This actually reverts 59927fb984de1703c67bc640c3e522d8b5276c73 > ("memcg: free mem_cgroup by RCU to fix oops"). > > Cc: Hugh Dickins > Signed-off-by: Li Zefan Very nice. Acked-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936769Ab3DIC6M (ORCPT ); Mon, 8 Apr 2013 22:58:12 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:33538 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934602Ab3DIC6K (ORCPT ); Mon, 8 Apr 2013 22:58:10 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.8.4 Message-ID: <516383AD.9010305@jp.fujitsu.com> Date: Tue, 09 Apr 2013 11:57:49 +0900 From: Kamezawa Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Li Zefan CC: Andrew Morton , Tejun Heo , Glauber Costa , Johannes Weiner , LKML , Cgroups , linux-mm@kvack.org, Hugh Dickins Subject: Re: [PATCH 12/12] memcg: don't need to free memcg via RCU or workqueue References: <5162648B.9070802@huawei.com> <51626570.8000400@huawei.com> In-Reply-To: <51626570.8000400@huawei.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2013/04/08 15:36), Li Zefan wrote: > Now memcg has the same life cycle with its corresponding cgroup, and > a cgroup is freed via RCU and then mem_cgroup_css_free() is called > in a work function, so we can simply call __mem_cgroup_free() in > mem_cgroup_css_free(). > > This actually reverts 59927fb984de1703c67bc640c3e522d8b5276c73 > ("memcg: free mem_cgroup by RCU to fix oops"). > > Cc: Hugh Dickins > Signed-off-by: Li Zefan Very nice. Acked-by: KAMEZAWA Hiroyuki