From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH 5/8] memcg: convert to use cgroup->id Date: Tue, 9 Apr 2013 11:02:20 +0800 Message-ID: <516384BC.7040302@huawei.com> References: <51627DA9.7020507@huawei.com> <51627E33.4090107@huawei.com> <20130408145702.GM17178@dhcp22.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130408145702.GM17178-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Michal Hocko Cc: Andrew Morton , Tejun Heo , Glauber Costa , KAMEZAWA Hiroyuki , Johannes Weiner , LKML , Cgroups , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org On 2013/4/8 22:57, Michal Hocko wrote: > On Mon 08-04-13 16:22:11, Li Zefan wrote: >> This is a preparation to kill css_id. >> >> Signed-off-by: Li Zefan > > This patch depends on the following patch, doesn't it? There is no > guarantee that id fits into short right now. Not such a big deal but > would be nicer to have that guarantee for bisectability. > Not necessary, because css_id still prevents us from creating too many cgroups. > The patch on its own looks good. > > Acked-by: Michal Hocko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx183.postini.com [74.125.245.183]) by kanga.kvack.org (Postfix) with SMTP id C8A626B0027 for ; Mon, 8 Apr 2013 23:03:32 -0400 (EDT) Message-ID: <516384BC.7040302@huawei.com> Date: Tue, 9 Apr 2013 11:02:20 +0800 From: Li Zefan MIME-Version: 1.0 Subject: Re: [PATCH 5/8] memcg: convert to use cgroup->id References: <51627DA9.7020507@huawei.com> <51627E33.4090107@huawei.com> <20130408145702.GM17178@dhcp22.suse.cz> In-Reply-To: <20130408145702.GM17178@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Andrew Morton , Tejun Heo , Glauber Costa , KAMEZAWA Hiroyuki , Johannes Weiner , LKML , Cgroups , linux-mm@kvack.org On 2013/4/8 22:57, Michal Hocko wrote: > On Mon 08-04-13 16:22:11, Li Zefan wrote: >> This is a preparation to kill css_id. >> >> Signed-off-by: Li Zefan > > This patch depends on the following patch, doesn't it? There is no > guarantee that id fits into short right now. Not such a big deal but > would be nicer to have that guarantee for bisectability. > Not necessary, because css_id still prevents us from creating too many cgroups. > The patch on its own looks good. > > Acked-by: Michal Hocko -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936789Ab3DIDDX (ORCPT ); Mon, 8 Apr 2013 23:03:23 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:23191 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934408Ab3DIDDV (ORCPT ); Mon, 8 Apr 2013 23:03:21 -0400 Message-ID: <516384BC.7040302@huawei.com> Date: Tue, 9 Apr 2013 11:02:20 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Michal Hocko CC: Andrew Morton , Tejun Heo , Glauber Costa , KAMEZAWA Hiroyuki , Johannes Weiner , LKML , Cgroups , Subject: Re: [PATCH 5/8] memcg: convert to use cgroup->id References: <51627DA9.7020507@huawei.com> <51627E33.4090107@huawei.com> <20130408145702.GM17178@dhcp22.suse.cz> In-Reply-To: <20130408145702.GM17178@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.68.215] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2013/4/8 22:57, Michal Hocko wrote: > On Mon 08-04-13 16:22:11, Li Zefan wrote: >> This is a preparation to kill css_id. >> >> Signed-off-by: Li Zefan > > This patch depends on the following patch, doesn't it? There is no > guarantee that id fits into short right now. Not such a big deal but > would be nicer to have that guarantee for bisectability. > Not necessary, because css_id still prevents us from creating too many cgroups. > The patch on its own looks good. > > Acked-by: Michal Hocko