From: Johannes Sixt <j.sixt@viscovery.net>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Roberto Tyley <roberto.tyley@gmail.com>,
git@vger.kernel.org
Subject: Re: commit-message attack for extracting sensitive data from rewritten Git history
Date: Tue, 09 Apr 2013 08:03:24 +0200 [thread overview]
Message-ID: <5163AF2C.2020107@viscovery.net> (raw)
In-Reply-To: <20130408215457.GB11227@sigill.intra.peff.net>
Am 4/8/2013 23:54, schrieb Jeff King:
> Yeah, it would make sense for filter-branch to have a "--map-commit-ids"
> option or similar that does the update. At first I thought it might take
> two passes, but I don't think it is necessary, as long as we traverse
> the commits topologically (i.e., you cannot have mentioned X in a commit
> that is an ancestor of X, so you do not have to worry about mapping it
> until after it has been processed).
Topological traversal is not sufficient. Consider this history:
o--A--o--
/ /
--o--B--o
If A mentions B (think of cherry-pick -x), then you must ensure that the
branch containing B was traversed first.
-- Hannes
next prev parent reply other threads:[~2013-04-09 6:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 23:17 commit-message attack for extracting sensitive data from rewritten Git history Roberto Tyley
2013-04-08 15:40 ` Junio C Hamano
2013-04-08 21:54 ` Jeff King
2013-04-09 6:03 ` Johannes Sixt [this message]
2013-04-09 17:01 ` Jeff King
2013-04-09 18:08 ` Roberto Tyley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163AF2C.2020107@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=roberto.tyley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.