From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPTbT-0007K0-E0 for qemu-devel@nongnu.org; Tue, 09 Apr 2013 04:08:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPTbS-0004NL-Ap for qemu-devel@nongnu.org; Tue, 09 Apr 2013 04:08:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPTbR-0004NB-VH for qemu-devel@nongnu.org; Tue, 09 Apr 2013 04:08:30 -0400 Message-ID: <5163CC76.3000204@redhat.com> Date: Tue, 09 Apr 2013 10:08:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1365190076-20268-1-git-send-email-kwolf@redhat.com> <20130408160319.GE22660@stefanha-thinkpad.redhat.com> <5162EDD2.1030304@redhat.com> <20130409080438.GA2922@dhcp-200-207.str.redhat.com> In-Reply-To: <20130409080438.GA2922@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] block: Vectored bdrv_writev_vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, stefanha@redhat.com Il 09/04/2013 10:04, Kevin Wolf ha scritto: >> > >> > Looks good, but given there are patches to fix it, I'm not sure it's >> > worth the trouble... > Shouldn't this perform even a little better? And we should get rid of > non-vectored interfaces in the block layer anyway. Yes, if you have a very fast disk it should. Network throughput with Orit's patches jumped from 2.9 Gbps to 4.2 Gbps. But savevm is not live, so it is not as important to make it really fast. Anyhow, since the patches are there to fix both the cause and the symptom, there's really no reason to hold either series. Paolo