From: Paolo Bonzini <pbonzini@redhat.com>
To: "\"陳韋任 (Wei-Ren Chen)\"" <chenwj@iis.sinica.edu.tw>
Cc: peter.maydell@linaro.org, proljc@gmail.com,
e.voevodin@samsung.com, qemu-devel@nongnu.org,
blauwirbel@gmail.com, aurelien@aurel32.net,
paul@codesourcery.com, afaerber@suse.de,
liguang <lig.fnst@cn.fujitsu.com>,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal
Date: Tue, 09 Apr 2013 10:11:37 +0200 [thread overview]
Message-ID: <5163CD39.9000007@redhat.com> (raw)
In-Reply-To: <20130409080529.GA86334@cs.nctu.edu.tw>
Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto:
> Hi liguang,
>
> Just to be curious, how much performance improvement this patch can get?
I think zero. It is indeed making the code a tiny bit more readable in
the 2nd/3rd/5th/6th hunks.
But the 1st and 4th hunks, which do
- num_insns = 0;
are wrong. I'm surprised the compiler doesn't report usage of an
uninitialized variable. liguang, how did you test them?
Paolo
> Regards,
> chenwj
next prev parent reply other threads:[~2013-04-09 8:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 3:45 [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal liguang
2013-04-09 8:05 ` 陳韋任 (Wei-Ren Chen)
2013-04-09 8:11 ` Paolo Bonzini [this message]
2013-04-09 8:21 ` li guang
2013-04-09 9:08 ` Peter Maydell
2013-04-10 0:28 ` li guang
2013-04-10 2:31 ` 陳韋任 (Wei-Ren Chen)
2013-04-10 2:38 ` li guang
2013-04-10 2:58 ` 陳韋任 (Wei-Ren Chen)
2013-04-10 3:03 ` li guang
2013-04-09 9:20 ` 陳韋任 (Wei-Ren Chen)
2013-04-11 2:12 ` li guang
2013-04-09 8:33 ` 陳韋任 (Wei-Ren Chen)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163CD39.9000007@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=chenwj@iis.sinica.edu.tw \
--cc=e.voevodin@samsung.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.