From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60580)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1UPUtE-0002Xr-Jy
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 05:30:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1UPUtA-0006EW-IW
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 05:30:56 -0400
Received: from greensocs.com ([87.106.252.221]:40405
	helo=s15328186.onlinehome-server.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1UPUtA-0006EK-4h
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 05:30:52 -0400
Message-ID: <5163DFC7.4050606@greensocs.com>
Date: Tue, 09 Apr 2013 11:30:47 +0200
From: =?ISO-8859-1?Q?KONRAD_Fr=E9d=E9ric?= <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1365495755-10902-1-git-send-email-hdegoede@redhat.com>
	<5163D31F.5060901@redhat.com>
In-Reply-To: <5163D31F.5060901@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer
 building after hw-dirs branch merge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Hans de Goede <hdegoede@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 09/04/2013 10:36, Paolo Bonzini wrote:
> Il 09/04/2013 10:22, Hans de Goede ha scritto:
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>   hw/9pfs/virtio-9p-device.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> Ouch, /me installs libcap-ng-devel.
>
> Thanks.
>
> Paolo
>
>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
>> index 43f930e..b476b81 100644
>> --- a/hw/9pfs/virtio-9p-device.c
>> +++ b/hw/9pfs/virtio-9p-device.c
>> @@ -12,11 +12,11 @@
>>    */
>>   
>>   #include "hw/virtio/virtio.h"
>> +#include "hw/virtio/virtio-9p.h"
[..]
>>   #include "virtio-9p.h"
Is that normal?

We have two virtio-9p.h:
./hw/9pfs/virtio-9p.h
./include/hw/virtio/virtio-9p.h

which can be confusing.

is it not better to re-rename virtio-9p.h => virtio-9p-device.h?
>> -#include "virtio-9p-device.h"
>>   
>>
>