From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V8 5/9] EXYNOS5: DWMMC: Initialise the local variable to avoid unwanted results.
Date: Tue, 09 Apr 2013 19:54:19 +0900 [thread overview]
Message-ID: <5163F35B.9070106@samsung.com> (raw)
In-Reply-To: <1364998113-13428-6-git-send-email-amarendra.xt@samsung.com>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 04/03/2013 11:08 PM, Amar wrote:
> This patch initialises the local variable 'shift' to zero.
> The uninitialised local variable 'shift' had garbage value and was
> resulting in unwnated results in the functions exynos5_get_mmc_clk()
> and exynos4_get_mmc_clk().
>
> Signed-off-by: Amar <amarendra.xt@samsung.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> ---
> Changes since V1:
> 1)Updated the function exynos5_mmc_set_clk_div() to receive
> 'device_i'd as input parameter instead of 'index'.
>
> Changes since V2:
> 1)Updation of commit message and resubmition of proper patch set.
>
> Changes since V3:
> 1)Removed the new API exynos5_mmc_set_clk_div() from clock.c,
> because existing API set_mmc_clk() can be used to set mmc clock.
>
> Changes since V4:
> 1)Updated the subject line to reflect the changes present in this patch.
> 2)Changes of the file arch/arm/include/asm/arch-exynos/clk.h which
> were present in this patch, have been moved out of this patch.
>
> Changes since V5:
> No change.
>
> Changes since V6:
> No change.
>
> Changes since V7:
> No change.
>
> arch/arm/cpu/armv7/exynos/clock.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c
> index 223660a..cf3247a 100644
> --- a/arch/arm/cpu/armv7/exynos/clock.c
> +++ b/arch/arm/cpu/armv7/exynos/clock.c
> @@ -613,7 +613,7 @@ static unsigned long exynos4_get_mmc_clk(int dev_index)
> (struct exynos4_clock *)samsung_get_base_clock();
> unsigned long uclk, sclk;
> unsigned int sel, ratio, pre_ratio;
> - int shift;
> + int shift = 0;
>
> sel = readl(&clk->src_fsys);
> sel = (sel >> (dev_index << 2)) & 0xf;
> @@ -662,7 +662,7 @@ static unsigned long exynos5_get_mmc_clk(int dev_index)
> (struct exynos5_clock *)samsung_get_base_clock();
> unsigned long uclk, sclk;
> unsigned int sel, ratio, pre_ratio;
> - int shift;
> + int shift = 0;
>
> sel = readl(&clk->src_fsys);
> sel = (sel >> (dev_index << 2)) & 0xf;
>
next prev parent reply other threads:[~2013-04-09 10:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 14:08 [U-Boot] [PATCH V8 0/9] EXYNOS5: Enable DWMMC, add FDT support for DWMMC and Amar
2013-04-03 14:08 ` [U-Boot] [PATCH V8 1/9] FDT: Add compatible string for DWMMC Amar
2013-04-03 14:08 ` [U-Boot] [PATCH V8 2/9] EXYNOS5: FDT: Add DWMMC device node data Amar
2013-04-03 14:08 ` [U-Boot] [PATCH V8 3/9] DWMMC: Initialise dwmci and resolve EMMC read write issues Amar
2013-04-09 10:49 ` Jaehoon Chung
2013-04-09 12:40 ` Amarendra Reddy
2013-04-03 14:08 ` [U-Boot] [PATCH V8 4/9] EXYNOS5: DWMMC: Added FDT support for DWMMC Amar
2013-04-09 10:53 ` Jaehoon Chung
2013-04-10 6:13 ` Amarendra Reddy
2013-04-12 11:20 ` Jaehoon Chung
2013-04-16 8:44 ` Amarendra Reddy
2013-04-23 3:57 ` Jaehoon Chung
2013-04-23 4:33 ` Amarendra Reddy
2013-04-03 14:08 ` [U-Boot] [PATCH V8 5/9] EXYNOS5: DWMMC: Initialise the local variable to avoid unwanted results Amar
2013-04-09 10:54 ` Jaehoon Chung [this message]
2013-04-03 14:08 ` [U-Boot] [PATCH V8 6/9] SMDK5250: Initialise and Enable DWMMC, support FDT and non-FDT Amar
2013-04-03 14:08 ` [U-Boot] [PATCH V8 7/9] MMC: APIs to support resize of EMMC boot partition Amar
2013-04-03 14:08 ` [U-Boot] [PATCH V8 8/9] SMDK5250: Enable EMMC booting Amar
2013-04-03 14:08 ` [U-Boot] [PATCH V8 9/9] COMMON: MMC: Command to support EMMC booting and to resize EMMC boot partition Amar
2013-04-05 6:21 ` Jaehoon Chung
2013-04-05 7:39 ` Amarendra Reddy
2013-04-09 10:55 ` Minkyu Kang
2013-04-09 11:27 ` Amarendra Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163F35B.9070106@samsung.com \
--to=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.