From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39343)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPX2z-0002en-LQ
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:49:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPX2x-00009q-9r
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:49:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58636)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UPX2x-00008j-20
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 07:49:07 -0400
Message-ID: <51640029.4080802@redhat.com>
Date: Tue, 09 Apr 2013 13:48:57 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1365495755-10902-1-git-send-email-hdegoede@redhat.com>
	<5163D31F.5060901@redhat.com> <5163DFC7.4050606@greensocs.com>
	<5163E102.6060302@redhat.com>
	<874nfgj60n.fsf@blackfin.pond.sub.org>
In-Reply-To: <874nfgj60n.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer
 building after hw-dirs branch merge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Hans de Goede <hdegoede@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>

Il 09/04/2013 13:30, Markus Armbruster ha scritto:
>>> >> We have two virtio-9p.h:
>>> >> ./hw/9pfs/virtio-9p.h
>>> >> ./include/hw/virtio/virtio-9p.h
>>> >> 
>>> >> which can be confusing.
>> >
>> > Yes, the first one is only included with a local path.  Though I think
>> > this is what confused my scripts.
> It'll confuse maintenance programmers, too.  Rename one of them?  For
> what it's worth, the second was named virtio-9p-device.h until you
> renamed & moved it.

The second isn't named virtio-9p.h.  It is named hw/virtio/virtio-9p.h.
 There is no -Iinclude/hw/virtio path, so you need the full path to
include it.

If you look at Linux, you have similarly include/scsi/scsi.h (for
#include <scsi/scsi.h>) and drivers/scsi/scsi.h (for #include "scsi.h").

Paolo