From: Paolo Bonzini <pbonzini@redhat.com>
To: quintela@redhat.com
Cc: kwolf@redhat.com, owasserm@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] migration: drop is_write complications
Date: Tue, 09 Apr 2013 13:55:17 +0200 [thread overview]
Message-ID: <516401A5.1020707@redhat.com> (raw)
In-Reply-To: <878v4sdj6q.fsf@elfo.elfo>
Il 09/04/2013 13:42, Juan Quintela ha scritto:
>> > @@ -556,11 +557,7 @@ static void qemu_fill_buffer(QEMUFile *f)
>> > int len;
>> > int pending;
>> >
>> > - if (!f->ops->get_buffer)
>> > - return;
> Why are we removing this test? this has nothing to do with the is_write
> removal?
This test assumes that it makes sense to call qemu_get_byte on a
write-opened QEMUFile. This is not true anymore after this patch.
After eliminating is_write, the right thing to do is abort.
Paolo
> And yes, having a better way of knowing that the operations are there
> looks like a good idea, but that is independent of this series.
next prev parent reply other threads:[~2013-04-09 11:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 11:29 [Qemu-devel] [PATCH 0/4] QEMUFile improvements and simplifications Paolo Bonzini
2013-04-08 11:29 ` [Qemu-devel] [PATCH 1/4] migration: set f->is_write and flush in add_to_iovec Paolo Bonzini
2013-04-09 11:32 ` Juan Quintela
2013-04-09 11:39 ` Paolo Bonzini
2013-04-08 11:29 ` [Qemu-devel] [PATCH 2/4] migration: use a single I/O operation when writev_buffer is not defined Paolo Bonzini
2013-04-09 11:38 ` Juan Quintela
2013-04-09 11:42 ` Paolo Bonzini
2013-04-08 11:29 ` [Qemu-devel] [PATCH 3/4] migration: drop is_write complications Paolo Bonzini
2013-04-09 11:42 ` Juan Quintela
2013-04-09 11:55 ` Paolo Bonzini [this message]
2013-04-09 12:17 ` Juan Quintela
2013-04-09 12:25 ` Paolo Bonzini
2013-04-08 11:29 ` [Qemu-devel] [PATCH 4/4] migration: simplify writev vs. non-writev logic Paolo Bonzini
2013-04-09 11:43 ` Juan Quintela
2013-04-09 11:53 ` Paolo Bonzini
2013-04-09 12:16 ` Juan Quintela
2013-04-09 12:22 ` Orit Wasserman
2013-04-09 12:58 ` [Qemu-devel] [PATCH 0/4] QEMUFile improvements and simplifications Juan Quintela
2013-04-10 12:48 ` Liuji (Jeremy)
2013-04-10 12:53 ` Paolo Bonzini
2013-04-10 18:29 ` Juan Quintela
2013-04-11 12:35 ` Liuji (Jeremy)
2013-04-10 12:55 ` Juan Quintela
2013-04-11 12:38 ` Liuji (Jeremy)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516401A5.1020707@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=owasserm@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.