From: "Jakub Narębski" <jnareb@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Thomas Rast <trast@student.ethz.ch>,
Stephen Boyd <bebarino@gmail.com>,
Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH v4 1/6] send-email: make annotate configurable
Date: Tue, 09 Apr 2013 15:51:36 +0200 [thread overview]
Message-ID: <51641CE8.4000704@gmail.com> (raw)
In-Reply-To: <1365356784-24872-2-git-send-email-felipe.contreras@gmail.com>
W dniu 07.04.2013 19:46, Felipe Contreras pisze:
> @@ -212,7 +212,8 @@ my %config_bool_settings = (
> "signedoffbycc" => [\$signed_off_by_cc, undef],
> "signedoffcc" => [\$signed_off_by_cc, undef], # Deprecated
> "validate" => [\$validate, 1],
> - "multiedit" => [\$multiedit, undef]
> + "multiedit" => [\$multiedit, undef],
> + "annotate" => [\$annotate, undef]
> );
Why not leave hanging "," to make it easier on future changes,
i.e.:
- "multiedit" => [\$multiedit, undef]
+ "multiedit" => [\$multiedit, undef],
+ "annotate" => [\$annotate, undef],
--
Jakub Narębski
next prev parent reply other threads:[~2013-04-09 13:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 17:46 [PATCH v4 0/6] send-email: configuration improvements Felipe Contreras
2013-04-07 17:46 ` [PATCH v4 1/6] send-email: make annotate configurable Felipe Contreras
2013-04-09 13:51 ` Jakub Narębski [this message]
2013-04-07 17:46 ` [PATCH v4 2/6] format-patch: improve head calculation for cover-letter Felipe Contreras
2013-04-07 17:46 ` [PATCH v4 3/6] format-patch: refactor branch name calculation Felipe Contreras
2013-04-07 17:46 ` [PATCH v4 4/6] log: update to OPT_BOOL Felipe Contreras
2013-04-07 17:46 ` [PATCH v4 5/6] format-patch: add format.cover-letter configuration Felipe Contreras
2013-04-07 19:34 ` Simon Ruderich
2013-04-07 22:32 ` Jonathan Nieder
2013-04-09 13:18 ` [PATCH] t/README: --immediate skips cleanup commands for failed tests Simon Ruderich
2013-04-09 19:16 ` Junio C Hamano
2013-04-09 21:48 ` [PATCH v2] " Simon Ruderich
2013-04-07 17:46 ` [PATCH v4 6/6] format-patch: trivial cleanups Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51641CE8.4000704@gmail.com \
--to=jnareb@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=barkalow@iabervon.org \
--cc=bebarino@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.