From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPZCX-0002jk-Ap for qemu-devel@nongnu.org; Tue, 09 Apr 2013 10:07:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPZCV-0007ts-K2 for qemu-devel@nongnu.org; Tue, 09 Apr 2013 10:07:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPZCV-0007tf-Cj for qemu-devel@nongnu.org; Tue, 09 Apr 2013 10:07:07 -0400 Message-ID: <51642084.6000401@redhat.com> Date: Tue, 09 Apr 2013 16:07:00 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1365442249-18259-1-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL] hw/ reorganization part 2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org Il 09/04/2013 15:40, Peter Maydell ha scritto: >> > {hw => include/hw/arm}/devices.h | 0 > Just noticed this is wrong -- devices.h contains prototypes > for various miscellaneous devices. For instance sm501 > is sh4. This doesn't belong in include/hw/arm/. I can fix these in a followup. I saw you also pointed to include/hw/arm.h. > (More generally I don't much like the include/hw/$ARCH/ > directories -- ideally all these headers should be > replaced by generic manipulations of properties...) Yes, they should. Paolo