All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: <sedat.dilek@gmail.com>
Cc: <kgdb-bugreport@lists.sourceforge.net>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: kdb: kgdb: CONFIG_DEBUG_RODATA setting?
Date: Tue, 9 Apr 2013 09:14:58 -0500	[thread overview]
Message-ID: <51642262.10902@windriver.com> (raw)
In-Reply-To: <CA+icZUUkEgv+e1q3v1kW5WhJdT1egZKc5o96zF2omcT0YtVE3w@mail.gmail.com>

On 04/09/2013 08:06 AM, Sedat Dilek wrote:

>  config DEBUG_RODATA
>  	bool "Write protect kernel read-only data structures"
> -	default y
>  	depends on DEBUG_KERNEL
> +	default n if KGDB
> +	default y
>  	---help---
>  	  Mark the kernel read-only data as write-protected in the pagetables,
>  	  in order to catch accidental (and incorrect) writes to such const


This is wrong and should not be merged.

A) You should not change these defaults in this manner

B) You have pointed out that the documentation is currently
   incorrect. The CONFIG_DEBUG_RODATA constraints were removed some time
   ago, per commit 3751d3e85cf693e10e2c47c03c8caa65e171099b (x86,kgdb:
   Fix DEBUG_RODATA limitation using text_poke())

Jason.


  reply	other threads:[~2013-04-09 14:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09 13:06 kdb: kgdb: CONFIG_DEBUG_RODATA setting? Sedat Dilek
2013-04-09 14:14 ` Jason Wessel [this message]
2013-04-09 14:26   ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51642262.10902@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sedat.dilek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.