From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@suse.com>
Subject: Re: OT: xen libvirt issue
Date: Tue, 09 Apr 2013 08:41:56 -0600
Message-ID: <516428B4.4000700@suse.com>
References: <3427165.VJZ1fcVilY@localhost> <7659328.YPt9AoC338@localhost>
	<20834.60368.423794.311886@mariner.uk.xensource.com>
	<2097106.TF58oyf9Ak@localhost>
	<20836.3074.239782.83930@mariner.uk.xensource.com>
	<8d7bf95388b41324a886ad590a94fa24.squirrel@mail.rmail.be>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <8d7bf95388b41324a886ad590a94fa24.squirrel@mail.rmail.be>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: AL13N <alien@rmail.be>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Marek Marczykowski <marmarek@invisiblethingslab.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

AL13N wrote:
>> AL13N writes ("Re: [Xen-devel] OT: xen libvirt issue"):
>>     
>>> i was more worried about the comments in the patch, ie: that it
>>> changes how tools using this (libvirt maybe) would need to be
>>> recoded.
>>>       
>> Yes, in order to fully fix these races there are a number of libvirt
>> patches needed as well.  I don't know exactly which libvirt trees
>> these are in but the libvirt fixes are pure fixes which won't break
>> anything that's not already broken.
>>
>> It is also the case that in theory the libxl fixes won't break
>> anything that's not already broken.  However, it turns out that some
>> versions of libvirt were already broken: at least some versions of
>> libvirt's libxl bindings had a bug in its timeout calculation code
>> which is triggered by timeout_modify(...{0,0}...), and the libxl patch
>> "libxl: fix stale timeout event callback race" exposes that bug which
>> was previously latent.
>>     
>
> FYI, applying these patches for me fixed the problem completely, i wasn't
> able to segfault libvirtd anymore.

I don't think you tried hard enough :).  But glad it is working for
you!  I still plan to improve shutdown event handling when I have some
time to work on the libxl driver.

Jim