Re: [PATCH] tools/ocaml: Fix library generation [and 1 more messages]

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 09/04/13 15:30, Ian Jackson wrote:
> Vincent Bernardoff writes ("[Xen-devel] [PATCH] tools/ocaml: Fix library generation"):
>> From: Vincent Bernardoff <vincent.bernardoff@citrix.com>
>>
>> Fix the commands given to the OCaml compiler to make the OCaml
>> bindings to Xen usable outside the build environment.
>>
>> Signed-off-by: Vincent Bernardoff <vincent.bernardoff@citrix.com>
> It would have been good to point out somewhere that the changes to
> Rules.mk don't just affect the commands given to the ocaml compiler
> but to all users of libxc, libxl etc.
>
> And I'm afraid, viewing the changes in that light, this amounts to
> reverting b7ee8d2f432f726a1154d172016d3f2b22757fe3 "tools build: link
> to specific library version (libxs, libxl, xenstore, xenstat)".
> (CCing Roger, author of that commit.)
>
> So I'm afraid this patch is not acceptable in this form.
>
> Is there no way to get the ocaml compiler to link against a specified
> library file without embedding the path into the executable ?
>
> Ian.

I was not aware of Rogers commit, but at the very least it break static
linking.

Furthermore,  the library directory paths are specified on the command
line, which take priority over system library paths.  The only way I can
see, given a brief read of the gcc manual, for the wrong versions to be
linked is if there are stale versions of the libraries present in the
build directory.

As far as I am concerned, having had to explicitly fix this up in
XenServer, commit b7ee8d2f432f726a1154d172016d3f2b22757fe3 should be
reverted, unless I am really misunderstanding the point of the patch.

~Andrew