From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] sh7750: Fix crash when accessing PVR/PRR/CVR
Date: Tue, 09 Apr 2013 16:52:30 +0200 [thread overview]
Message-ID: <51642B2E.5010407@suse.de> (raw)
In-Reply-To: <CAFEAcA_GQQckymhf30_Pi1rja+sDzKXXCAGifVpcsqcntTfkgg@mail.gmail.com>
Am 08.04.2013 14:52, schrieb Peter Maydell:
> On 26 March 2013 14:35, Andreas Färber <afaerber@suse.de> wrote:
>> Am 26.03.2013 13:20, schrieb Peter Maydell:
>>> Commit b350ab75 causes segfaults on accesses to PVR/PRR/CVR because
>>> it tries to call SUPERH_CPU_GET_CLASS() on a pointer that isn't a
>>> QOM object. Fix this by getting the actual QOM CPU object first.
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>> ---
>>> Tested with the r2d image/instructions from
>>> https://oss.renesas.com/modules/document/?Getting%20Started%20with%20SH4%20and%20QEMU
>>
>> Oops, reproduces with the test image from the QEMU Wiki as well. Seems
>> to be a result of cherry-picking this commit before the full SH7750
>> QOM'ification.
>>
>> Is this blocking any work of yours? Otherwise I would try rebasing my
>> SH7750 patches so that s->cpu becomes a SuperHCPU as expected here.
>> (Not sure if simply reverting my offending patch still works?)
>
> Ping -- were you planning to submit these patches soon or should
> we just commit this patch to fix the breakage for now?
Submitted now, sorry for the delay.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-04-09 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 12:20 [Qemu-devel] [PATCH] sh7750: Fix crash when accessing PVR/PRR/CVR Peter Maydell
2013-03-26 14:35 ` Andreas Färber
2013-03-26 14:44 ` Peter Maydell
2013-04-08 12:52 ` Peter Maydell
2013-04-09 14:52 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51642B2E.5010407@suse.de \
--to=afaerber@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.