All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, quintela@redhat.com,
	pl@kamp.de, qemu-devel@nongnu.org, owasserm@redhat.com,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] migration: initialize RAM to zero
Date: Tue, 09 Apr 2013 16:56:12 +0200	[thread overview]
Message-ID: <51642C0C.6010607@redhat.com> (raw)
In-Reply-To: <8738uzet89.fsf@blackfin.pond.sub.org>

Il 09/04/2013 15:20, Markus Armbruster ha scritto:
>> > -#if defined(CONFIG_VALGRIND)
>> > -    if (running_on_valgrind < 0) {
>> > -        /* First call, test whether we are running on Valgrind.
>> > -           This is a substitute for RUNNING_ON_VALGRIND from valgrind.h. */
>> > -        const char *ld = getenv("LD_PRELOAD");
>> > -        running_on_valgrind = (ld != NULL && strstr(ld, "vgpreload"));
>> > +    if ((intptr_t) ptr == -1) {
> Recommend ptr == MAP_FAILED
> 

Worth respinning?

Paolo

  reply	other threads:[~2013-04-09 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09 12:52 [Qemu-devel] [PATCH v2] migration: initialize RAM to zero Paolo Bonzini
2013-04-09 13:20 ` Markus Armbruster
2013-04-09 14:56   ` Paolo Bonzini [this message]
2013-04-09 15:04     ` Markus Armbruster
2013-04-09 15:22     ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51642C0C.6010607@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=owasserm@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.