From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
Daniel Kiper <daniel.kiper@oracle.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Xen-devel] [PATCH 4/8] kexec: add infrastructure for handling kexec images
Date: Tue, 9 Apr 2013 17:17:36 +0100 [thread overview]
Message-ID: <51643F20.3010907@citrix.com> (raw)
In-Reply-To: <5163E2FE02000078000CB9B7@nat28.tlf.novell.com>
On 09/04/13 08:44, Jan Beulich wrote:
>>>> On 08.04.13 at 20:59, David Vrabel <david.vrabel@citrix.com> wrote:
>> + ret = kimage_add_page(image, page_to_mfn(page) << PAGE_SHIFT);
>
> Constructs like this aren't portable. You ought to use
> page_to_maddr(), and have the called function have paddr_t
> instead of unsigned long as the respective parameter.
I will make this change but it isn't clear to me why this isn't portable.
David
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-04-09 16:17 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 18:59 [PATCHv3 0/8] kexec: extend kexec hypercall for use with pv-ops kernels David Vrabel
2013-04-08 18:59 ` David Vrabel
2013-04-08 18:59 ` [PATCH 1/8] x86: give FIX_EFI_MPF its own fixmap entry David Vrabel
2013-04-08 18:59 ` David Vrabel
2013-04-09 7:27 ` [Xen-devel] " Jan Beulich
2013-04-09 16:15 ` David Vrabel
2013-04-09 16:15 ` David Vrabel
2013-04-09 7:27 ` Jan Beulich
2013-04-08 18:59 ` [PATCH 2/8] xen: make GUEST_HANDLE_64() and uint64_aligned_t available everywhere David Vrabel
2013-04-08 18:59 ` David Vrabel
2013-04-08 18:59 ` [PATCH 3/8] kexec: add public interface for improved load/unload sub-ops David Vrabel
2013-04-08 18:59 ` David Vrabel
2013-04-09 7:32 ` Jan Beulich
2013-04-09 7:32 ` [Xen-devel] " Jan Beulich
2013-04-12 11:56 ` David Vrabel
2013-04-12 13:01 ` Jan Beulich
2013-04-12 13:01 ` Jan Beulich
2013-04-12 11:56 ` David Vrabel
2013-04-08 18:59 ` [PATCH 4/8] kexec: add infrastructure for handling kexec images David Vrabel
2013-04-08 18:59 ` David Vrabel
2013-04-09 7:44 ` Jan Beulich
2013-04-09 7:44 ` [Xen-devel] " Jan Beulich
2013-04-09 16:17 ` David Vrabel [this message]
2013-04-10 8:36 ` Jan Beulich
2013-04-10 8:36 ` [Xen-devel] " Jan Beulich
2013-04-09 16:17 ` David Vrabel
2013-04-08 18:59 ` [PATCH 5/8] kexec: extend hypercall with improved load/unload ops David Vrabel
2013-04-08 18:59 ` David Vrabel
2013-04-09 21:02 ` Daniel Kiper
2013-04-15 18:58 ` David Vrabel
2013-04-15 18:58 ` David Vrabel
2013-04-16 12:05 ` Daniel Kiper
2013-04-16 12:05 ` Daniel Kiper
2013-04-16 14:57 ` David Vrabel
2013-04-16 14:57 ` David Vrabel
2013-04-09 21:02 ` Daniel Kiper
2013-04-08 18:59 ` [PATCH 6/8] xen: kexec crash image when dom0 crashes David Vrabel
2013-04-08 18:59 ` David Vrabel
2013-04-09 21:11 ` Daniel Kiper
2013-04-09 21:11 ` Daniel Kiper
2013-04-08 18:59 ` [PATCH 7/8] libxc: add hypercall buffer arrays David Vrabel
2013-04-08 18:59 ` David Vrabel
2013-04-08 18:59 ` [PATCH 8/8] libxc: add API for kexec hypercall David Vrabel
2013-04-08 18:59 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51643F20.3010907@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=daniel.kiper@oracle.com \
--cc=kexec@lists.infradead.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.