Re: [PATCH 1/6] hfp_hf_bluez5: Add audio card .connect() for HFP 1.6

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

Hi Vinicius,

On 04/08/2013 05:40 PM, Vinicius Costa Gomes wrote:
> ---
>   plugins/hfp_hf_bluez5.c | 30 +++++++++++++++++++++++++++++-
>   1 file changed, 29 insertions(+), 1 deletion(-)

Patch has been applied.

> +	struct hfp *hfp = ofono_handsfree_card_get_data(card);
> +	struct hfp_slc_info *info =&hfp->info;
> +
> +	if ((info->hf_features&  HFP_HF_FEATURE_CODEC_NEGOTIATION&&
> +			info->ag_features&  HFP_AG_FEATURE_CODEC_NEGOTIATION)) {

I removed the extra parentheses in a follow on commit.

> +		struct cb_data *cbd = cb_data_new(cb, data);
> +
> +		g_at_chat_send(info->chat, "AT+BCC", NULL, bcc_cb, cbd, g_free);
> +		return;
> +	}
> +
> +	/*
> +	 * If any side (remote or local) doesn't support codec negotiation,
> +	 * fallback to direct SCO connection. Calling connect_sco()
> +	 * hands the connection responsibility to the core, so no need
> +	 * to call the callback
> +	 */
> +	ofono_handsfree_card_connect_sco(card);
>   }
>
>   static struct ofono_handsfree_card_driver hfp16_hf_driver = {

Regards,
-Denis