From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58979)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1UPf8v-0003A0-34
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 16:27:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1UPf8u-0001EK-62
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 16:27:49 -0400
Received: from greensocs.com ([87.106.252.221]:45075
	helo=s15328186.onlinehome-server.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1UPf8t-0001EC-WF
	for qemu-devel@nongnu.org; Tue, 09 Apr 2013 16:27:48 -0400
Message-ID: <516479BC.30206@greensocs.com>
Date: Tue, 09 Apr 2013 22:27:40 +0200
From: =?ISO-8859-1?Q?KONRAD_Fr=E9d=E9ric?= <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1365495755-10902-1-git-send-email-hdegoede@redhat.com>
	<5163D31F.5060901@redhat.com> <87a9p7h606.fsf@codemonkey.ws>
In-Reply-To: <87a9p7h606.fsf@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix virtio-9p no longer
 building after hw-dirs branch merge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Hans de Goede <hdegoede@redhat.com>

On 09/04/2013 21:13, Anthony Liguori wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> Il 09/04/2013 10:22, Hans de Goede ha scritto:
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>>   hw/9pfs/virtio-9p-device.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion
>> Ouch, /me installs libcap-ng-devel.
> On a fresh F18, I tried to find all the deps needed that can be
> reasonably installed.  This is what I came up with:
>
> # yum install xen-devel iasl libfdt-devel libcap-ng-devel \
>    spice-server-devel gnutls-devel cyrus-sasl-devel libjpeg-turbo-devel \
>    libpng-devel uuid-devel xfsprogs-devel ncurses-devel brlapi-devel \
>    libcurl-devel bluez-libs-devel libiscsi-devel libcap-ng-devel \
>    spice-protocol SDL-devel libcap-devel usbredir-devel libseccomp-devel \
>    ceph-devel
>
> Still missing GlusterFS, VDE, and iscsi.  F18 doesn't seem to
> package these at appropriate versions.
>
> Regards,
>
> Anthony Liguori
Isn't libattr-devel needed as well for virtio-9p?

I needed it to test my patch-set this morning.
>
>> Thanks.
>>
>> Paolo
>>
>>> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
>>> index 43f930e..b476b81 100644
>>> --- a/hw/9pfs/virtio-9p-device.c
>>> +++ b/hw/9pfs/virtio-9p-device.c
>>> @@ -12,11 +12,11 @@
>>>    */
>>>   
>>>   #include "hw/virtio/virtio.h"
>>> +#include "hw/virtio/virtio-9p.h"
>>>   #include "hw/i386/pc.h"
>>>   #include "qemu/sockets.h"
>>>   #include "virtio-9p.h"
>>>   #include "fsdev/qemu-fsdev.h"
>>> -#include "virtio-9p-device.h"
>>>   #include "virtio-9p-xattr.h"
>>>   #include "virtio-9p-coth.h"
>>>   
>>>