All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Dylan Reid <dgreid@chromium.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ALSA: hda - Apply codec delay to wallclock.
Date: Tue, 09 Apr 2013 20:55:59 -0700	[thread overview]
Message-ID: <5164E2CF.2050207@linux.intel.com> (raw)
In-Reply-To: <1365470430-22292-1-git-send-email-dgreid@chromium.org>

On 4/8/13 6:20 PM, Dylan Reid wrote:
> For playback add the codec-side delay to the timestamp, for capture
> subtract it.  This brings the timestamps in line with the time that
> was recently added to the delay reporting.
>
> Signed-off-by: Dylan Reid <dgreid@chromium.org>
> ---
> Changes since v1:
> Calculate nsec from frames, subtract delay for playback as well as
> capture.

> +	return (nsec > codec_nsecs) ? nsec - codec_nsecs : 0;

Is this correct? I would think for capture you need to add the delay, 
and subtract it for playback?
-Pierre

  parent reply	other threads:[~2013-04-10  3:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09  1:20 [PATCH v2] ALSA: hda - Apply codec delay to wallclock Dylan Reid
2013-04-09  6:03 ` Takashi Iwai
2013-04-10  3:55 ` Pierre-Louis Bossart [this message]
2013-04-10  5:30   ` Dylan Reid
2013-04-10 14:29     ` Pierre-Louis Bossart
2013-04-10 15:16       ` Takashi Iwai
2013-04-12  1:17         ` Pierre-Louis Bossart
2013-04-12  8:55           ` Takashi Iwai
2013-04-13  8:55             ` Takashi Iwai
2013-04-15  8:02               ` Dylan Reid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5164E2CF.2050207@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dgreid@chromium.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.