From: Paolo Bonzini <pbonzini@redhat.com>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: peter.maydell@linaro.org, proljc@gmail.com,
e.voevodin@samsung.com, qemu-devel@nongnu.org,
blauwirbel@gmail.com, paul@codesourcery.com, afaerber@suse.de,
aurelien@aurel32.net, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] translate: cleanup gen_intermediate_code_internal
Date: Wed, 10 Apr 2013 09:44:19 +0200 [thread overview]
Message-ID: <51651853.6090701@redhat.com> (raw)
In-Reply-To: <1365564652-26981-1-git-send-email-lig.fnst@cn.fujitsu.com>
Il 10/04/2013 05:30, liguang ha scritto:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
> target-arm/translate.c | 17 ++++++++---------
> target-i386/translate.c | 17 ++++++++---------
> target-mips/translate.c | 16 ++++++++--------
> 3 files changed, 24 insertions(+), 26 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 35a21be..c0c080d 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -9806,11 +9806,10 @@ static inline void gen_intermediate_code_internal(CPUARMState *env,
> cpu_M0 = tcg_temp_new_i64();
> next_page_start = (pc_start & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE;
> lj = -1;
> - num_insns = 0;
Nack. Did you even try to read what I and Wei-Ren Chen were trying to
tell you?
Paolo
> max_insns = tb->cflags & CF_COUNT_MASK;
> - if (max_insns == 0)
> + if (max_insns == 0) {
> max_insns = CF_COUNT_MASK;
> -
> + }
> gen_tb_start();
>
> tcg_clear_temp_count();
> @@ -9889,9 +9888,9 @@ static inline void gen_intermediate_code_internal(CPUARMState *env,
> if (search_pc) {
> j = tcg_ctx.gen_opc_ptr - tcg_ctx.gen_opc_buf;
> if (lj < j) {
> - lj++;
> - while (lj < j)
> - tcg_ctx.gen_opc_instr_start[lj++] = 0;
> + while (++lj < j) {
> + tcg_ctx.gen_opc_instr_start[lj] = 0;
> + }
> }
> tcg_ctx.gen_opc_pc[lj] = dc->pc;
> gen_opc_condexec_bits[lj] = (dc->condexec_cond << 4) | (dc->condexec_mask >> 1);
> @@ -10028,9 +10027,9 @@ done_generating:
> #endif
> if (search_pc) {
> j = tcg_ctx.gen_opc_ptr - tcg_ctx.gen_opc_buf;
> - lj++;
> - while (lj <= j)
> - tcg_ctx.gen_opc_instr_start[lj++] = 0;
> + while (++lj <= j) {
> + tcg_ctx.gen_opc_instr_start[lj] = 0;
> + }
> } else {
> tb->size = dc->pc - pc_start;
> tb->icount = num_insns;
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index 7596a90..9c5e1a3 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -8319,11 +8319,10 @@ static inline void gen_intermediate_code_internal(CPUX86State *env,
> dc->is_jmp = DISAS_NEXT;
> pc_ptr = pc_start;
> lj = -1;
> - num_insns = 0;
> max_insns = tb->cflags & CF_COUNT_MASK;
> - if (max_insns == 0)
> + if (max_insns == 0) {
> max_insns = CF_COUNT_MASK;
> -
> + }
> gen_tb_start();
> for(;;) {
> if (unlikely(!QTAILQ_EMPTY(&env->breakpoints))) {
> @@ -8338,9 +8337,9 @@ static inline void gen_intermediate_code_internal(CPUX86State *env,
> if (search_pc) {
> j = tcg_ctx.gen_opc_ptr - tcg_ctx.gen_opc_buf;
> if (lj < j) {
> - lj++;
> - while (lj < j)
> - tcg_ctx.gen_opc_instr_start[lj++] = 0;
> + while (++lj < j) {
> + tcg_ctx.gen_opc_instr_start[lj] = 0;
> + }
> }
> tcg_ctx.gen_opc_pc[lj] = pc_ptr;
> gen_opc_cc_op[lj] = dc->cc_op;
> @@ -8387,9 +8386,9 @@ static inline void gen_intermediate_code_internal(CPUX86State *env,
> /* we don't forget to fill the last values */
> if (search_pc) {
> j = tcg_ctx.gen_opc_ptr - tcg_ctx.gen_opc_buf;
> - lj++;
> - while (lj <= j)
> - tcg_ctx.gen_opc_instr_start[lj++] = 0;
> + while (++lj <= j) {
> + tcg_ctx.gen_opc_instr_start[lj] = 0;
> + }
> }
>
> #ifdef DEBUG_DISAS
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index b7f8203..d1e5d84 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -15571,10 +15571,10 @@ gen_intermediate_code_internal (CPUMIPSState *env, TranslationBlock *tb,
> #else
> ctx.mem_idx = ctx.hflags & MIPS_HFLAG_KSU;
> #endif
> - num_insns = 0;
> max_insns = tb->cflags & CF_COUNT_MASK;
> - if (max_insns == 0)
> + if (max_insns == 0) {
> max_insns = CF_COUNT_MASK;
> + }
> LOG_DISAS("\ntb %p idx %d hflags %04x\n", tb, ctx.mem_idx, ctx.hflags);
> gen_tb_start();
> while (ctx.bstate == BS_NONE) {
> @@ -15595,9 +15595,9 @@ gen_intermediate_code_internal (CPUMIPSState *env, TranslationBlock *tb,
> if (search_pc) {
> j = tcg_ctx.gen_opc_ptr - tcg_ctx.gen_opc_buf;
> if (lj < j) {
> - lj++;
> - while (lj < j)
> - tcg_ctx.gen_opc_instr_start[lj++] = 0;
> + while (++lj < j) {
> + tcg_ctx.gen_opc_instr_start[lj] = 0;
> + }
> }
> tcg_ctx.gen_opc_pc[lj] = ctx.pc;
> gen_opc_hflags[lj] = ctx.hflags & MIPS_HFLAG_BMASK;
> @@ -15678,9 +15678,9 @@ done_generating:
> *tcg_ctx.gen_opc_ptr = INDEX_op_end;
> if (search_pc) {
> j = tcg_ctx.gen_opc_ptr - tcg_ctx.gen_opc_buf;
> - lj++;
> - while (lj <= j)
> - tcg_ctx.gen_opc_instr_start[lj++] = 0;
> + while (++lj <= j) {
> + tcg_ctx.gen_opc_instr_start[lj] = 0;
> + }
> } else {
> tb->size = ctx.pc - pc_start;
> tb->icount = num_insns;
>
next prev parent reply other threads:[~2013-04-10 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 3:30 [Qemu-devel] [PATCH] translate: cleanup gen_intermediate_code_internal liguang
2013-04-10 7:44 ` Paolo Bonzini [this message]
2013-04-10 7:55 ` li guang
2013-04-10 9:54 ` Paolo Bonzini
2013-04-11 2:11 ` li guang
2013-04-11 6:23 ` Paolo Bonzini
2013-04-11 6:42 ` li guang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51651853.6090701@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=e.voevodin@samsung.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.