From: Serban Constantinescu <Serban.Constantinescu@arm.com>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Android Kernel Team <kernel-team@android.com>,
John Stultz <john.stultz@linaro.org>,
Dave Butcher <Dave.Butcher@arm.com>
Subject: Re: [PATCH v2 1/7] staging: android: binder: clean-up uint32_t types
Date: Wed, 10 Apr 2013 09:40:55 +0100 [thread overview]
Message-ID: <51652597.4000102@arm.com> (raw)
In-Reply-To: <CAMP5XgdPQeKBXCV5XHqkRi6NsJAhF5NdV_dEf_7gv2=GWs3v3w@mail.gmail.com>
On 10/04/13 01:11, Arve Hjønnevåg wrote:
> On Tue, Apr 9, 2013 at 3:00 AM, Serban Constantinescu
> <serban.constantinescu@arm.com> wrote:
>> uint32_t types are used inconsistently throughout the driver. This patch
>> replaces "uint32_t" types with "unsigned int" ones.
>>
>
> I don't like this change. You fix the header in a later patch to use
> explicit sizes, so it does not make sense to do the opposite here.
As mentioned before we do not need this change. I will drop it from the
patch set.
Thanks,
Serban
next prev parent reply other threads:[~2013-04-10 8:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 10:00 [PATCH v2 0/7] Android Binder IPC Fixes Serban Constantinescu
2013-04-09 10:00 ` [PATCH v2 1/7] staging: android: binder: clean-up uint32_t types Serban Constantinescu
2013-04-10 0:11 ` Arve Hjønnevåg
2013-04-10 8:40 ` Serban Constantinescu [this message]
2013-04-09 10:00 ` [PATCH v2 2/7] staging: android: binder: replace IOCTL types with user-exportable types Serban Constantinescu
2013-04-10 0:17 ` Arve Hjønnevåg
2013-04-09 10:00 ` [PATCH v2 3/7] staging: android: binder: fix binder interface for 64bit compat layer Serban Constantinescu
2013-04-09 23:48 ` Arve Hjønnevåg
2013-04-10 13:01 ` Serban Constantinescu
2013-04-10 22:12 ` Arve Hjønnevåg
2013-04-11 15:13 ` Serban Constantinescu
2013-04-11 20:38 ` Arve Hjønnevåg
2013-04-09 10:00 ` [PATCH v2 4/7] staging: android: binder: fix BINDER_SET_MAX_THREADS declaration Serban Constantinescu
2013-04-09 23:53 ` Arve Hjønnevåg
2013-04-10 12:37 ` Serban Constantinescu
2013-04-10 21:50 ` Arve Hjønnevåg
2013-04-09 10:00 ` [PATCH v2 5/7] staging: android: binder: fix BC_FREE_BUFFER ioctl declaration Serban Constantinescu
2013-04-09 23:55 ` Arve Hjønnevåg
2013-04-09 10:00 ` [PATCH v2 6/7] staging: android: binder: fix alignment issues Serban Constantinescu
2013-04-09 23:58 ` Arve Hjønnevåg
2013-04-10 16:39 ` Serban Constantinescu
2013-04-10 22:30 ` Arve Hjønnevåg
2013-04-11 19:02 ` Serban Constantinescu
2013-04-11 21:40 ` Arve Hjønnevåg
2013-04-09 10:00 ` [PATCH v2 7/7] staging: android: binder: replace types with portable ones Serban Constantinescu
2013-04-10 0:09 ` Arve Hjønnevåg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51652597.4000102@arm.com \
--to=serban.constantinescu@arm.com \
--cc=Dave.Butcher@arm.com \
--cc=arve@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.