From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Marczykowski Subject: Re: libxl: hotplug scripts and backend_domid != 0 Date: Wed, 10 Apr 2013 13:36:34 +0200 Message-ID: <51654EC2.1000802@invisiblethingslab.com> References: <515DA023.70107@invisiblethingslab.com> <1365592473.26448.31.camel@zakaz.uk.xensource.com> <51654B76.8020606@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3672773240003217929==" Return-path: In-Reply-To: <51654B76.8020606@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Cc: George Dunlap , Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============3672773240003217929== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig7E1F24205F4BA5D8025E4E45" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7E1F24205F4BA5D8025E4E45 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10.04.2013 13:22, Roger Pau Monn=C3=A9 wrote: > On 10/04/13 13:14, Ian Campbell wrote: >> On Thu, 2013-04-04 at 16:45 +0100, Marek Marczykowski wrote: >>> Hi, >>> >>> Currently when using backend outside of dom0 (for at least one device= ) libxl >>> force udev call method of hotplug scripts for entire system. >> >> Roger, do you remember why? Was it just because this change was >> relatively late in the 4.2 cycle and we were being conservative? >> >>> Maybe this can be >>> changed to: >>> a) if backend_domid=3D=3D0, proceed according to run_hotplug_scipts >>> b) if backend_domid!=3D0, ignore run_hotplug_scipts and always use ud= ev >>> ? >>> >>> Does it sound sensible? >> >> It does, although we are now relatively late in the 4.3 cycle so I'm n= ot >> sure it would be appropriate. George? >> >> I think Roger is intending to implement a new scheme for driver domain= s >> etc in 4.4, which may make this particular issue disappear anyway. >=20 > Since run_hotplug_scripts is a global variable, not per-device, changin= g > it when backend_domid !=3D 0 for a certain device might cause trouble t= o > other devices, or guests launched concurrently. Also udev scripts check= > run_hotplug_scripts in xenstore, so changing it while there are guests > being created or destroyed might also cause trouble. So this is the reason why I don't want to change it's value, but ignore f= or non-dom0 backends (for which it wouldn't change anything anyway). --=20 Best Regards / Pozdrawiam, Marek Marczykowski Invisible Things Lab --------------enig7E1F24205F4BA5D8025E4E45 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJRZU7DAAoJENuP0xzK19cseNgH/3ltf/adLxm1YTP2KxhcX3xb 4VSzX0m5quRHhrz/RtJJS6sk0Ehg4+Upxloo8GFSu12YQOyhvWVkQUEHYEW8fSsN BuLhcVZ+6trcpT5o9WANctV6+hRYXyM8D8MLVv+azPGGAjjqXP+1Pp2k+Fbd3m6K 3hZ9NAttlRYW+N+jJo5GjwjkrQKlNcGtZa3ICl3i/BY0ySGOeuHAPHUhV37ZP2Yx bLZvHx8dE6eUzByAqYAbHEFAZoJwjEuF5QGTuzXqgqVUuVVaBDIgu5PtkLYgZ09Q 4ByanHrml1XH2GY8zvoGcv1jUbgyiiYu5ztFn9QSR9NBt7rMGy0LpYbuGoLHcSI= =UD+D -----END PGP SIGNATURE----- --------------enig7E1F24205F4BA5D8025E4E45-- --===============3672773240003217929== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3672773240003217929==--