All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Choonho Son <choonho.son@gmail.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xl: fix xl config parser
Date: Wed, 10 Apr 2013 17:51:57 +0200	[thread overview]
Message-ID: <51658A9D.4040604@citrix.com> (raw)
In-Reply-To: <1365599333.27868.50.camel@zakaz.uk.xensource.com>

On 10/04/13 15:08, Ian Campbell wrote:
> On Wed, 2013-04-10 at 08:52 +0100, Choonho Son wrote:
>> Bug: xl lexical analyzer cannot parse keyword which has .(dot) character like vif.default.script
>>
>> ref: 733b9c524dbc2bec318bfc3588ed1652455d30ec
>> Error log: /etc/xen/xl.conf:28: config parsing error near `.default.script="vif-bridge"': lexical error
> 
> Hrm. Roger, how did this ever work for you?

I have no idea what on hell I did to test this options. Dunno if somehow
I managed to not include this diff on the patches I sent. This should be
added for sure.

> 
>>
>> Signed-off-by: Choonho Son <choonho.son@gmail.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>

>> ---
>>  tools/libxl/libxlu_cfg_l.l |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/tools/libxl/libxlu_cfg_l.l b/tools/libxl/libxlu_cfg_l.l
>> index efac884..d5241e1 100644
>> --- a/tools/libxl/libxlu_cfg_l.l
>> +++ b/tools/libxl/libxlu_cfg_l.l
>> @@ -52,7 +52,7 @@ void xlu__cfg_yyset_column(int  column_no, yyscan_t yyscanner);
>>  
>>  %%
>>  
>> -[a-z][_0-9a-z]*         {
>> +[a-z][._0-9a-z]*         {
>>                            yylval->string= xlu__cfgl_strdup(ctx,yytext);
>>                            GOT(IDENT);
>>                          }
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-04-10 15:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10  7:52 [PATCH] xl: fix xl config parser Choonho Son
2013-04-10 13:08 ` Ian Campbell
2013-04-10 15:51   ` Roger Pau Monné [this message]
2013-04-11 12:18     ` Ian Jackson
2013-04-12  7:56       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51658A9D.4040604@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=choonho.son@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.