From: John Crispin <john@phrozen.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 2/2] MIPS: implement pcibios_get_phb_of_node
Date: Wed, 10 Apr 2013 18:53:22 +0200 [thread overview]
Message-ID: <51659902.2080505@phrozen.org> (raw)
In-Reply-To: <CAErSpo4ih-Kgp4LxX1MDodac-eoPo=Mu1d6ex8oNnaEEc_GQnw@mail.gmail.com>
On 10/04/13 18:31, Bjorn Helgaas wrote:
> On Thu, Apr 4, 2013 at 12:01 PM, Gabor Juhos<juhosg@openwrt.org> wrote:
>> The of_node field of the device assigned to a
>> PCI bus is used during scanning of the PCI bus.
>> However on MIPS, the of_node field is assigned
>> only after the bus has been scanned.
>>
>> Implement the architecture specific version of
>> 'pcibios_get_phb_of_node'. Which ensures that the
>> PCI driver core will initialize the of_node field
>> before starting the scan.
>>
>> Also remove the local assignment of bus->dev.of_node,
>> it is not needed after the patch.
>>
>> Signed-off-by: Gabor Juhos<juhosg@openwrt.org>
>
> I removed the __weak annotation from include/linux/pci.h and applied
> this patch to my pci/gabor-get-of-node. Give it a try and make sure
> it solves your problem. If so, and Ralph approves, I can push both
> for v3.10. It should appear at
> http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/gabor-get-of-node
> soon.
>
> Or if you prefer, you can take them through the MIPS tree.
>
> Bjorn
Hi,
having them go via the PCI tree is fine. I will mark them as "Other
Subsystem" in our Patchwork
John
next prev parent reply other threads:[~2013-04-10 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 18:01 [PATCH 1/2] pci/of: remove weak annotation of pcibios_get_phb_of_node Gabor Juhos
2013-04-04 18:01 ` [PATCH 2/2] MIPS: implement pcibios_get_phb_of_node Gabor Juhos
2013-04-10 16:31 ` Bjorn Helgaas
2013-04-10 16:53 ` John Crispin [this message]
2013-04-11 17:32 ` Gabor Juhos
2013-04-11 17:35 ` Bjorn Helgaas
2013-04-11 17:39 ` Gabor Juhos
2013-04-10 15:46 ` [PATCH 1/2] pci/of: remove weak annotation of pcibios_get_phb_of_node Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51659902.2080505@phrozen.org \
--to=john@phrozen.org \
--cc=bhelgaas@google.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.